Drop openHAB 3.4 support #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Cutrer <cody@cutrer.us>
SemanticTags.add was only in core for a short time, and not during any full release Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
ccutrer
force-pushed
the
remove-oh3.4-compat
branch
from
96f9623
to
e1cccda
Compare
|
Mark this as breaking, to trigger v6.0 ? That way OH3.x people won't auto upgrade to it. |
|
Definitely. I don’t plan on submitting it until we really need to though. |
|
Recently added @deprecated
|
|
I would vote for proceeding with this sooner rather than later. I'm finding more and more need to add OH version guards. |
|
While I think of it, a self reminder that we can include an issue tagged with release summary to have a longer description about a release. See #62 |
|
We should look into this for 4.3 release. I'm betting nobody using 3.x is also using jruby. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.