Merge pull request #15 from openhealthalgorithms/error-management

Error management

actions/algorithm.go

@@ -96,10 +96,10 @@ func AlgorithmHandler(c echo.Context) error {
 		GoalContent:      *glc,
 	}
 
-	hs, hg, hr, hd, hrs, err := hearts.Process(*o, colorChartPath, countriesPath)
-	if err != nil {
-		return ErrorResponse(c, err, 500)
-	}
+	hs, hg, hr, hd, hrs, _ := hearts.Process(*o, colorChartPath, countriesPath)
+	// if err != nil {
+	// 	return ErrorResponse(c, err, 500)
+	// }
 
 	output := models.NewOutput(*o.Config.Algorithm)
 	output.Assessments = hs

pkg/version.go

@@ -1,6 +1,6 @@
 package pkg
 
-const version = "v1.5.0"
+const version = "v1.6.0"
 
 // GetVersion returns the current version
 func GetVersion() string {

pkg/version_test.go

@@ -0,0 +1,12 @@
+package pkg
+
+import (
+	"testing"
+)
+
+func TestGetVersion(t *testing.T) {
+	vers := version
+	if GetVersion() != vers {
+		t.Errorf("GetVersion(): expected %s, actual %s", vers, GetVersion())
+	}
+}

tools/calculate.go

@@ -1,6 +1,7 @@
 package tools
 
 import (
+	"math"
 	"strings"
 )
 
@@ -18,7 +19,7 @@ func CalculateAge(age float64, unit string) float64 {
 		}
 	}
 
-	return calAge
+	return math.Ceil(calAge*100) / 100
 }
 
 // CalculateExercise to minutes and moderate type weekly

tools/calculate_test.go

@@ -0,0 +1,28 @@
+package tools
+
+import (
+	"testing"
+)
+
+func TestCalculateAge(t *testing.T) {
+	type ageTest struct {
+		value  float64
+		unit   string
+		result float64
+	}
+
+	var ageTests = []ageTest{
+		{25, "year", 25},
+		{12, "month", 1},
+		{17, "week", 0.33},
+		{715, "day", 1.96},
+		{17, "hours", 17},
+	}
+
+	for _, at := range ageTests {
+		actual := CalculateAge(at.value, at.unit)
+		if actual != at.result {
+			t.Errorf("CalculateAge(%f, %s): expected %f, actual %f", at.value, at.unit, at.result, actual)
+		}
+	}
+}

tools/strings_test.go

@@ -234,3 +234,23 @@ func TestSliceStringEqual(t *testing.T) {
 		}
 	}
 }
+
+func TestGetFullGenderText(t *testing.T) {
+	type genderTest struct {
+		str    string
+		output string
+	}
+
+	var genderTests = []genderTest{
+		{"m", "male"},
+		{"f", "female"},
+		{"t", "female"},
+	}
+
+	for _, sas := range genderTests {
+		actual := GetFullGenderText(sas.str)
+		if actual != sas.output {
+			t.Errorf("GetFullGenderText(%s): expected %s, actual %s", sas.str, sas.output, actual)
+		}
+	}
+}