adios2: Update to 2.10.1 #2040
Merged
adios2: Update to 2.10.1 #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
force-pushed
the
adios2-2.10.1
branch
from
9c10bcc
to
6dfc85d
Compare
Change PIC value to TRUE As at https://github.com/ornladios/ADIOS2/tree/master/scripts/build_scripts Explicitly pass CMAKE_**_COMPILER options Remove unused options ``` CMake Warning: 2024-10-10T11:52:05.9700227Z Manually-specified variables were not used by the project: 2024-10-10T11:52:05.9700853Z 2024-10-10T11:52:05.9701038Z CMAKE_FC_COMPILER 2024-10-10T11:52:05.9701539Z CMAKE_SKIP_INSTALL_RPATH ``` And do not use `-DCMAKE_SKIP_RPATH:BOOL=ON` since it leads to build errors Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
adios2-2.10.1
branch
from
6dfc85d
to
3cd32f1
Compare
|
One of the tests dumps, core. Hmm. Is it a broken test or an upstream regression? |
Current error: ``` Log file: ./tests/libs/adios2/tests/family-gnu14-mpich/arrays_read.log 2024-10-10T13:31:18.3670468Z terminate called after throwing an instance of 'std::logic_error' 2024-10-10T13:31:18.3676365Z what(): ␛[1;36m[Thu Oct 10 13:30:59 2024]␛[1;34m [ADIOS2 EXCEPTION]␛[0m <Engine> <BP5Reader> <NotifyEngineNoVarsQuery> : You've called InquireVariable() when the IO is empty and outside a BeginStep/EndStep pair. If this is code that is newly transititioning to the BP5 file engine, you may be relying upon deprecated behaviour. If you intend to use ADIOS using the Begin/EndStep interface, move all InquireVariable calls inside the BeginStep/EndStep pair. If intending to use random-access file mode, change your Open() mode parameter to Mode::ReadRandomAccess.␛[0m ``` Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
|
Fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.