From 3cd32f1718e99226252297b3826a0c92eb5008cd Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Thu, 10 Oct 2024 13:58:28 +0300 Subject: [PATCH 1/2] adios2: Update to 2.10.1 Change PIC value to TRUE As at https://github.com/ornladios/ADIOS2/tree/master/scripts/build_scripts Explicitly pass CMAKE_**_COMPILER options Remove unused options ``` CMake Warning: 2024-10-10T11:52:05.9700227Z Manually-specified variables were not used by the project: 2024-10-10T11:52:05.9700853Z 2024-10-10T11:52:05.9701038Z CMAKE_FC_COMPILER 2024-10-10T11:52:05.9701539Z CMAKE_SKIP_INSTALL_RPATH ``` And do not use `-DCMAKE_SKIP_RPATH:BOOL=ON` since it leads to build errors Signed-off-by: Martin Tzvetanov Grigorov --- components/io-libs/adios2/SPECS/adios2.spec | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/components/io-libs/adios2/SPECS/adios2.spec b/components/io-libs/adios2/SPECS/adios2.spec index 21322a69db..2a1c2a56de 100644 --- a/components/io-libs/adios2/SPECS/adios2.spec +++ b/components/io-libs/adios2/SPECS/adios2.spec @@ -20,7 +20,7 @@ Summary: The Adaptable IO System v2 (ADIOS2) Name: %{pname}-%{compiler_family}-%{mpi_family}%{PROJ_DELIM} -Version: 2.8.3 +Version: 2.10.1 Release: 1%{?dist} License: Apache License 2.0 Group: %{PROJ_NAME}/io-libs @@ -101,10 +101,10 @@ export MPICXX=mpicxx cmake \ -DCMAKE_INSTALL_PREFIX=%{install_path} \ -DCMAKE_BUILD_TYPE=Release \ + -DCMAKE_C_COMPILER=${MPICC} \ + -DCMAKE_CXX_COMPILER=${MPICXX} \ -DBUILD_SHARED_LIBS=ON \ - -DCMAKE_SKIP_INSTALL_RPATH:BOOL=ON \ - -DCMAKE_SKIP_RPATH:BOOL=ON \ - -DCMAKE_POSITION_INDEPENDENT_CODE=ON \ + -DCMAKE_POSITION_INDEPENDENT_CODE=TRUE \ -DADIOS2_USE_MPI=ON \ -DADIOS2_USE_HDF5=ON -DHDF5_ROOT="${HDF5_DIR}" \ -DADIOS2_USE_ZeroMQ=OFF \ From 5f95bd2e73ac603d9dc755626548da4351cc136b Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Mon, 21 Oct 2024 11:31:12 +0300 Subject: [PATCH 2/2] Try with ReadRandomAccess mode when reading a file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Current error: ``` Log file: ./tests/libs/adios2/tests/family-gnu14-mpich/arrays_read.log 2024-10-10T13:31:18.3670468Z terminate called after throwing an instance of 'std::logic_error' 2024-10-10T13:31:18.3676365Z what(): ␛[1;36m[Thu Oct 10 13:30:59 2024]␛[1;34m [ADIOS2 EXCEPTION]␛[0m : You've called InquireVariable() when the IO is empty and outside a BeginStep/EndStep pair. If this is code that is newly transititioning to the BP5 file engine, you may be relying upon deprecated behaviour. If you intend to use ADIOS using the Begin/EndStep interface, move all InquireVariable calls inside the BeginStep/EndStep pair. If intending to use random-access file mode, change your Open() mode parameter to Mode::ReadRandomAccess.␛[0m ``` Signed-off-by: Martin Tzvetanov Grigorov --- tests/libs/adios2/tests/arrays_read.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libs/adios2/tests/arrays_read.cpp b/tests/libs/adios2/tests/arrays_read.cpp index 759d15c2c3..405a2d6f2b 100644 --- a/tests/libs/adios2/tests/arrays_read.cpp +++ b/tests/libs/adios2/tests/arrays_read.cpp @@ -38,7 +38,7 @@ int main(int argc, char *argv[]) adios2::IO bpIO = adios.DeclareIO("ReadBP"); /** Engine derived class, spawned to start IO operations */ - adios2::Engine bpReader = bpIO.Open(filename, adios2::Mode::Read); + adios2::Engine bpReader = bpIO.Open(filename, adios2::Mode::ReadRandomAccess); const std::map variables = bpIO.AvailableVariables();