Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential Offer leftovers #79

Closed
wants to merge 1 commit into from
Closed

Credential Offer leftovers #79

wants to merge 1 commit into from
+0 −4

Conversation

paulbastian
Copy link
Collaborator

Closes #78

@paulbastian paulbastian linked an issue Nov 23, 2023 that may be closed by this pull request
SD-JWT-VC Credential Offer leftovers #78
Closed
tlodderstedt
tlodderstedt requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@tlodderstedt tlodderstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to drop the whole section.

TimoGlastra
TimoGlastra reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo currently point to https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html, which currently hosts draft 11 of OID4VCI and still includes the credential offer objects.

Should the draft at openid be updated, or can we point this spec specifically to a different version of the draft?

@tlodderstedt
Copy link
Contributor

This repo currently point to https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html, which currently hosts draft 11 of OID4VCI and still includes the credential offer objects.

Should the draft at openid be updated, or can we point this spec specifically to a different version of the draft?

Why should the credential offer go away? We just changed it to point to configuration ids only.

@paulbastian
Copy link
Collaborator Author

There is just no need to add additional rules as credential offer is now format agnostic pointing to credential supported ids

@Sakurann
Copy link
Contributor

this PR is superseded by PR #96 because that PR removes credential offer section altogether.

@paulbastian
Copy link
Collaborator Author

Closing this in favor of #96

@paulbastian paulbastian closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra left review comments

@tlodderstedt tlodderstedt tlodderstedt requested changes

@Sakurann Sakurann Sakurann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SD-JWT-VC Credential Offer leftovers
4 participants
@paulbastian @tlodderstedt @Sakurann @TimoGlastra