Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorials: Crypto Suites, hash alg sections, small others #85

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

editorials: Crypto Suites, hash alg sections, small others #85

wants to merge 8 commits into from

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented Dec 13, 2023 •
edited
Loading

This PR Closes #69

  • aligns the use of the defined terms Issuer, Holder and Verifiers within the text
  • adds the section hash algorithms
  • adds Wallet Instance Attestation as defined term (since it was mentioned in the text as it were a defined term)

tlodderstedt
tlodderstedt requested changes Jan 6, 2024
View reviewed changes
draft-oid4vc-haip-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-oid4vc-haip-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-oid4vc-haip-sd-jwt-vc.md Outdated Show resolved Hide resolved
@peppelinux @tlodderstedt
Apply suggestions from code review - Torsten's
7d5d576 
Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
tlodderstedt
tlodderstedt requested changes Jan 30, 2024
View reviewed changes
draft-oid4vc-haip-sd-jwt-vc.md Outdated Show resolved Hide resolved
peppelinux and others added 3 commits May 25, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sakurann Sakurann Awaiting requested review from Sakurann

@tlodderstedt tlodderstedt Awaiting requested review from tlodderstedt

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

first paragraph section 8 needs clarification
3 participants
@peppelinux @tlodderstedt @Sakurann