Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTC-801: not super user can only manage his roles #163

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

OTC-801: not super user can only manage his roles #163

wants to merge 1 commit into from

Conversation

lruzicki
Copy link
Contributor

@lruzicki lruzicki commented Apr 11, 2023 •
edited
Loading

Ticket:
https://openimis.atlassian.net/browse/OTC-801

Changes:

  • to allow managing only allowed roles for master user I implemented that if he is not super user, he can only fetch (and create other users if has perms) only those roles that he has

Worth considering:

  • PR implements approach where only super admin can create roles, because user with "create_roles_perms" wont see what they have created

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lruzicki lruzicki marked this pull request as draft April 11, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

@delcroip delcroip Awaiting requested review from delcroip

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lruzicki