Feature/cqi 149: password validator for user form creation #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/UserMasterPanel.js
Outdated
| @@ -309,6 +328,9 @@ const UserMasterPanel = (props) => { | |||
| </InputAdornment> | |||
| } | |||
| /> | |||
| <Typography color={passwordScore >= 2 ? "primary" : "error"} className={classes.passwordFeedback}> | |||
There was a problem hiding this comment.
I suggest you to create a variable which will explicitly say what do you check here. So instead of color={passwordScore >= 2 ? "primary" : "error"} I would declare a variable: const IS_PASSWORD_SECURED = passwordScore >= 2; and then use it like that: color={IS_PASSWORD_SECURED ? "primary" : "error"}. It will be more readable.
olewandowski1
requested changes
May 16, 2024
|
olewandowski1
approved these changes
May 22, 2024
There was a problem hiding this comment.
LGTM @lruzicki . I'll merge it once BE will be merged. Let me know about it.
@olewandowski1 BE is merged, you can merge FE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
https://openimis.atlassian.net/browse/CQI-149
Changes:
How was it tested?
Examples of use:
Weak password - password policy errors
Password policy met but the password is still weak
Medium password, user can save the form, but it recommends him strengthening password (score 2 from library)
Strong password (score 3 from library)
Very strong password (score 4 from library)
