CM-230: tasks refactor #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Good job. I left some comments with some questions and some minor improvement of code. @jdolkowski
delcroip
added a commit
that referenced
this pull request
Dec 16, 2023
* CM-147: use fe-template * CM-147: workflows added, minor changes * CM-147: workflows update * CM-138: User Groups Management implementation (#1) * CM-139: base project configuration, eslint, main route * CM-139: basic structure of tasks view * CM-139: basic view of task traiage * CM-139: basic view of task triage * CM-139: task preview improvements * CM-139: import fix * CM-138: user groups management page and basic searcher * CM-138: reducer, actions, fetchTaskGroups, searcher * CM-138: taskExecutorsPicker, taskGroupPage, taskGroupHeadPanel * CM-138: fetch task group, clear on unmount * OTC-138: remove package-lock json * CM-138: implementation of create/update mutation, executors picker fix * CM-138: removal of console log * CM-138: filtering, sorting, searching improvements, executorsPicker fixes * CM-138: create PERFORM_MUTATION and adjust existing logic, constants fix * CM-138: name of function changed * CM-138: TaskExecutorsPicker fixes * CM-138: component name changed - TaskDetailsPage * CM-139: add core tasks fe (#2) * CM-139: add core tasks fe * CM-143: fix eslint * CM-139: add styles * CM-139: address PR comments * CM-139: remove intl * CM-144: add my tasks fe (#3) * CM-144: add my tasks fe * CM-144: remove unused variables * CM-139: fix issues from QA (#4) * CM-139: fix comparing edited and fetch object * CM-139: fix formatting of taskGroup * CM-231: Added Admin main menu contribution * CM-145: make initial policy empty (#7) * CM-145: make initial policy empty * CM-145: fix eslint * CM-138: fix mutation label and action type (#6) * add-server-deploy-workflow: add file (#9) * CM-139: change perms on frontend (#8) * CM-139: fix comparing edited and fetch object * CM-139: fix formatting of taskGroup * CM-139: change perms to search tasks * CM-232: use IDs in mutation label (#11) * CM-144: fix tasks (#10) * CM-144: add my tasks fe * CM-144: remove unused variables * CM-144: fix tasks * CM-144: fix eslint * Update README.md * CM-230: tasks refactor (#12) * CM-230: fix modularity of the module * CM-230: refactor code * CM-230: refactor code * CM-230: fix headers * CM-230: add beneficiary crud tasks * CM-230: eslint * CM-230: address pr review * CM-230: address pr review * CM-230: fix eslint * CM-299: show business status on searcher (#13) * CM-332: fetch tasks only for particular searcher (#14) * CM-332: fetch tasks only for particular searcher * CM-332: fix eslint --------- Co-authored-by: Jan <j.dolkowski@soldevelo.com> * CM-327: change the way how task updates are fetched (#15) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * hotfix: fix parsing schema in task (#16) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * CM-327: fetch task only after it is updated (#18) * CM-327: change the way how task updates are fetched * CM-327: make sure task is fetched after it is uploaded --------- Co-authored-by: Jan <j.dolkowski@soldevelo.com> * hotfix: fix displaying deleted groups (#17) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * add-sonar-ci: add sonar files (#20) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * MERGING RELEASE branches (#19) * CM-332: fetch tasks only for particular searcher (#14) * CM-332: fetch tasks only for particular searcher * CM-332: fix eslint --------- Co-authored-by: Jan <j.dolkowski@soldevelo.com> * CM-327: change the way how task updates are fetched (#15) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * hotfix: fix parsing schema in task (#16) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * CM-327: fetch task only after it is updated (#18) * CM-327: change the way how task updates are fetched * CM-327: make sure task is fetched after it is uploaded --------- Co-authored-by: Jan <j.dolkowski@soldevelo.com> * hotfix: fix displaying deleted groups (#17) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * add-sonar-ci: add sonar files (#20) Co-authored-by: Jan <j.dolkowski@soldevelo.com> --------- Co-authored-by: Jan <jdolkowski@soldevelo.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com> --------- Co-authored-by: olewandowski <olewandowski@soldevelo.com> Co-authored-by: olewandowski1 <109145288+olewandowski1@users.noreply.github.com> Co-authored-by: Jan <jdolkowski@soldevelo.com> Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com> Co-authored-by: sniedzielski <52816247+sniedzielski@users.noreply.github.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com> Co-authored-by: Dragos DOBRE <dragos.dobre@swisstph.ch> Co-authored-by: Hiren Soni <65155846+hirensoni913@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openimis.atlassian.net/browse/CM-230
This PR will improve modularity of the module and adds beneficiary crud searcher.
It needs:
openimis/openimis-be-tasks_management_py#16
openimis/openimis-be-social_protection_py#32
openimis/openimis-fe-social_protection_js#47