Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-139: add core tasks fe #2

Merged
merged 5 commits into from
Jul 6, 2023
Merged

CM-139: add core tasks fe #2

merged 5 commits into from
Jul 6, 2023

Conversation

jdolkowski
Copy link
Contributor

@jdolkowski jdolkowski commented Jul 5, 2023 •
edited
Loading

@jdolkowski jdolkowski marked this pull request as draft July 5, 2023 00:29
@jdolkowski jdolkowski mentioned this pull request Jul 5, 2023
Merged
@jdolkowski jdolkowski marked this pull request as ready for review July 5, 2023 09:03
sniedzielski
sniedzielski reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to my comments @jdolkowski
Please remember to add documentation to README section with some published components etc, redux states.

src/components/TaskPreviewPanel.js Outdated Show resolved Hide resolved
src/pages/TaskDetailsPage.js Outdated Show resolved Hide resolved
src/actions.js Outdated Show resolved Hide resolved
olewandowski1
olewandowski1 requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@olewandowski1 olewandowski1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdolkowski I left you some comments.

In terms of function components, I saw that you changed TaskDetailsPage.js completely and you're not using hooks like useHistory, useModulesManager, etc. I do not want to force you to use them, but I recommend using them. They make the whole code shorter and more readable. Moreover, we do not have redundant warnings in console. Let me know what do you think about that.

@sniedzielski

@jdolkowski
Copy link
Contributor Author

@sniedzielski I added readme
@olewandowski1 i updated functional components

I also resolved all the comments addressed by you.

@sniedzielski sniedzielski self-requested a review July 6, 2023 13:53
@sniedzielski sniedzielski merged commit 4ef4687 into develop Jul 6, 2023
@sniedzielski sniedzielski deleted the feature/CM-139 branch July 6, 2023 14:12
delcroip added a commit that referenced this pull request Dec 16, 2023
@delcroip @olewandowski1
@jdolkowski @dborowiecki @sniedzielski @dragos-dobre @hirensoni913
MERGING release/23.10 into main (#23)
6ec7457 
* CM-147: use fe-template

* CM-147: workflows added, minor changes

* CM-147: workflows update

* CM-138: User Groups Management implementation (#1)

* CM-139: base project configuration, eslint, main route

* CM-139: basic structure of tasks view

* CM-139: basic view of task traiage

* CM-139: basic view of task triage

* CM-139: task preview improvements

* CM-139: import fix

* CM-138: user groups management page and basic searcher

* CM-138: reducer, actions, fetchTaskGroups, searcher

* CM-138: taskExecutorsPicker, taskGroupPage, taskGroupHeadPanel

* CM-138: fetch task group, clear on unmount

* OTC-138: remove package-lock json

* CM-138: implementation of create/update mutation, executors picker fix

* CM-138: removal of console log

* CM-138: filtering, sorting, searching improvements, executorsPicker fixes

* CM-138: create PERFORM_MUTATION and adjust existing logic, constants fix

* CM-138: name of function changed

* CM-138: TaskExecutorsPicker fixes

* CM-138: component name changed - TaskDetailsPage

* CM-139: add core tasks fe (#2)

* CM-139: add core tasks fe

* CM-143: fix eslint

* CM-139: add styles

* CM-139: address PR comments

* CM-139: remove intl

* CM-144: add my tasks fe (#3)

* CM-144: add my tasks fe

* CM-144: remove unused variables

* CM-139: fix issues from QA (#4)

* CM-139: fix comparing edited and fetch object

* CM-139: fix formatting of taskGroup

* CM-231: Added Admin main menu contribution

* CM-145: make initial policy empty (#7)

* CM-145: make initial policy empty

* CM-145: fix eslint

* CM-138: fix mutation label and action type (#6)

* add-server-deploy-workflow: add file (#9)

* CM-139: change perms on frontend (#8)

* CM-139: fix comparing edited and fetch object

* CM-139: fix formatting of taskGroup

* CM-139: change perms to search tasks

* CM-232: use IDs in mutation label (#11)

* CM-144: fix tasks (#10)

* CM-144: add my tasks fe

* CM-144: remove unused variables

* CM-144: fix tasks

* CM-144: fix eslint

* Update README.md

* CM-230: tasks refactor (#12)

* CM-230: fix modularity of the module

* CM-230: refactor code

* CM-230: refactor code

* CM-230: fix headers

* CM-230: add beneficiary crud tasks

* CM-230: eslint

* CM-230: address pr review

* CM-230: address pr review

* CM-230: fix eslint

* CM-299: show business status on searcher (#13)

* CM-332: fetch tasks only for particular searcher (#14)

* CM-332: fetch tasks only for particular searcher

* CM-332: fix eslint

---------

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* CM-327: change the way how task updates are fetched (#15)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* hotfix: fix parsing schema in task (#16)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* CM-327: fetch task only after it is updated (#18)

* CM-327: change the way how task updates are fetched

* CM-327: make sure task is fetched after it is uploaded

---------

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* hotfix: fix displaying deleted groups (#17)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* add-sonar-ci: add sonar files (#20)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* MERGING RELEASE branches (#19)

* CM-332: fetch tasks only for particular searcher (#14)

* CM-332: fetch tasks only for particular searcher

* CM-332: fix eslint

---------

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* CM-327: change the way how task updates are fetched (#15)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* hotfix: fix parsing schema in task (#16)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* CM-327: fetch task only after it is updated (#18)

* CM-327: change the way how task updates are fetched

* CM-327: make sure task is fetched after it is uploaded

---------

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* hotfix: fix displaying deleted groups (#17)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

* add-sonar-ci: add sonar files (#20)

Co-authored-by: Jan <j.dolkowski@soldevelo.com>

---------

Co-authored-by: Jan <jdolkowski@soldevelo.com>
Co-authored-by: Jan <j.dolkowski@soldevelo.com>

---------

Co-authored-by: olewandowski <olewandowski@soldevelo.com>
Co-authored-by: olewandowski1 <109145288+olewandowski1@users.noreply.github.com>
Co-authored-by: Jan <jdolkowski@soldevelo.com>
Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com>
Co-authored-by: sniedzielski <52816247+sniedzielski@users.noreply.github.com>
Co-authored-by: Jan <j.dolkowski@soldevelo.com>
Co-authored-by: Dragos DOBRE <dragos.dobre@swisstph.ch>
Co-authored-by: Hiren Soni <65155846+hirensoni913@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniedzielski sniedzielski sniedzielski approved these changes

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

@olewandowski1 olewandowski1 Awaiting requested review from olewandowski1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdolkowski @sniedzielski @olewandowski1