-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONI-255: Basic allowed task source picker and filtering. #52
Conversation
@@ -46,6 +48,14 @@ class TaskGroupHeadPanel extends FormPanel { | |||
edited, classes, readOnly, | |||
} = this.props; | |||
const taskGroup = { ...edited }; | |||
const { rights } = this.props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The properties have already been destructured from this.props. Add rights to the destructured properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: Mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I left one comment and we have to do something about those issues found by linter.
Quality Gate passedIssues Measures |
Ticket: https://openimis.atlassian.net/browse/ONI-255
Changes: