Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONI-255: Basic allowed task source picker and filtering. #52

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 5, 2024

Ticket: https://openimis.atlassian.net/browse/ONI-255

Changes:

  • Added "allowed task source" dropdown
  • Based on its values "task source" dropdown is filtered

@ghost ghost requested review from olewandowski1 and sniedzielski June 6, 2024 12:00
@ghost ghost marked this pull request as ready for review June 6, 2024 12:04
@ghost ghost changed the title Feature/oni 255 ONI-255: Basic allowed task source picker and filtering. Jun 6, 2024
@@ -46,6 +48,14 @@ class TaskGroupHeadPanel extends FormPanel {
edited, classes, readOnly,
} = this.props;
const taskGroup = { ...edited };
const { rights } = this.props;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The properties have already been destructured from this.props. Add rights to the destructured properties.

Copy link
Collaborator

@olewandowski1 olewandowski1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Mistake

Copy link
Collaborator

@olewandowski1 olewandowski1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I left one comment and we have to do something about those issues found by linter.

Copy link

sonarcloud bot commented Jun 7, 2024

@delcroip delcroip merged commit 7ce985b into develop Jun 26, 2024
5 of 6 checks passed
@delcroip delcroip deleted the feature/ONI-255 branch June 26, 2024 07:04
@dborowiecki dborowiecki restored the feature/ONI-255 branch June 26, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants