Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-968: added changelog for tasks #54

Merged
merged 1 commit into from
Aug 2, 2024
Merged

CM-968: added changelog for tasks #54

merged 1 commit into from
Aug 2, 2024

Conversation

sniedzielski
Copy link
Contributor

@sniedzielski sniedzielski commented Aug 2, 2024 •
edited
Loading

TICKET: https://openimis.atlassian.net/browse/CM-968

Peek 2024-08-02 15-48

Added changelog for task entity to track history

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

lruzicki
lruzicki approved these changes Aug 2, 2024
View reviewed changes
Copy link

@lruzicki lruzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments for code refactor, but I'm fine if you don't address them. If you are sure that null/none values will be handled properly in this PR I give it a green light

@sniedzielski sniedzielski merged commit 77c59b1 into develop Aug 2, 2024
5 of 6 checks passed
@sniedzielski sniedzielski deleted the feature/CM-968 branch August 2, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lruzicki lruzicki lruzicki approved these changes

@jdolkowski jdolkowski Awaiting requested review from jdolkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sniedzielski @lruzicki