removed medical, contribution, policy modules that aren't related to social protection #146
Conversation
…social protection
There was a problem hiding this comment.
I left one comment, please take a look into that.
@delcroip FYI I added proposition related to ContributionPlan/PaymentPlan
| "npm": "@openimis/fe-policyholder@git+https://github.com/openimis/openimis-fe-policyholder_js.git#develop" | ||
| }, | ||
| { | ||
| "name": "ContributionPlanModule", |
There was a problem hiding this comment.
@Shahzaibahmad97 ContributionPlan module cannot be removed due to containing PaymentPlan (used in social protection payment flow too) mechanism inside this module.
@delcroip FYI maybe we can distinguish this modules to have separate one for PaymentPlan and for ContributionPlan, what do you think?
There was a problem hiding this comment.
@sniedzielski rest of the modules can be removed?
There was a problem hiding this comment.
I think yes, the only module which cannot be removed is 'ContributionPlan'. I'll check also on my computer to double check this.
There was a problem hiding this comment.
I'll wait for it then. As when discussing with Andrea, he wasn't sure what this contribution plan part does and therefore we wanted to remove this or hide this through permissions at least.
There was a problem hiding this comment.
Yes, maybe the easiest way is to do in the same way as you did for health facility in previous PRs. Based on permission - ContributionPlan can be hided.
The second approach is to move PaymentPlan to separarate module - it could take more time, PaymentPlan is also used in Claim BatchRun - therefore some regression tests might be required to ensure nothing is broken after this potentlal change.
@delcroip Let me know what do you think about two strategies how to hide ContributionPlan.
This PR is to remove some modules that are still included in Medical MIS and aren't part of the Social Protection. Most of these modules have also been excluded already through permissions and weren't visible therefore its also better to exclude them to reduce confusion for anyone starting on social protection project.