Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed medical, contribution, policy modules that aren't related to social protection #146

Open
wants to merge 1 commit into
base: coreMIS
Choose a base branch
from
Open

removed medical, contribution, policy modules that aren't related to social protection #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions openimis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@
"name": "LocationModule",
"npm": "@openimis/fe-location@git+https://github.com/openimis/openimis-fe-location_js.git#develop"
},
{
"name": "MedicalModule",
"npm": "@openimis/fe-medical@git+https://github.com/openimis/openimis-fe-medical_js.git#develop"
},
{
"name": "ProfileModule",
"npm": "@openimis/fe-profile@git+https://github.com/openimis/openimis-fe-profile_js.git#develop"
Expand All @@ -66,22 +62,10 @@
"name": "CalculationModule",
"npm": "@openimis/fe-calculation@git+https://github.com/openimis/openimis-fe-calculation_js.git#develop"
},
{
"name": "PolicyHolderModule",
"npm": "@openimis/fe-policyholder@git+https://github.com/openimis/openimis-fe-policyholder_js.git#develop"
},
{
"name": "ContributionPlanModule",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shahzaibahmad97 ContributionPlan module cannot be removed due to containing PaymentPlan (used in social protection payment flow too) mechanism inside this module.
@delcroip FYI maybe we can distinguish this modules to have separate one for PaymentPlan and for ContributionPlan, what do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sniedzielski rest of the modules can be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes, the only module which cannot be removed is 'ContributionPlan'. I'll check also on my computer to double check this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for it then. As when discussing with Andrea, he wasn't sure what this contribution plan part does and therefore we wanted to remove this or hide this through permissions at least.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe the easiest way is to do in the same way as you did for health facility in previous PRs. Based on permission - ContributionPlan can be hided.

The second approach is to move PaymentPlan to separarate module - it could take more time, PaymentPlan is also used in Claim BatchRun - therefore some regression tests might be required to ensure nothing is broken after this potentlal change.

@delcroip Let me know what do you think about two strategies how to hide ContributionPlan.

"npm": "@openimis/fe-contribution_plan@git+https://github.com/openimis/openimis-fe-contribution_plan_js.git#develop"
},
{
"name": "PaymentCycleModule",
"npm": "@openimis/fe-payment_cycle@git+https://github.com/openimis/openimis-fe-payment_cycle_js.git#develop"
},
{
"name": "ContractModule",
"npm": "@openimis/fe-contract@git+https://github.com/openimis/openimis-fe-contract_js.git#develop"
},
{
"name": "TasksManagementModule",
"npm": "@openimis/fe-tasks_management@git+https://github.com/openimis/openimis-fe-tasks_management_js.git#develop"
Expand Down