Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340401: DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java fail with assert(_stack_base != nullptr) failed: Sanity check #21091

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/nmt/memMapPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ static bool vma_touches_thread_stack(const void* from, const void* to, const Thr
// Very rarely however is a VMA backing a thread stack folded together with another adjacent VMA by the
// kernel. That can happen, e.g., for non-java threads that don't have guard pages.
// Therefore we go for the simplest way here and check for intersection between VMA and thread stack.
return range_intersects(from, to, (const void*)t->stack_end(), (const void*)t->stack_base());
return range_intersects(from, to, (const void*)t->stack_end(), (const void*)t->stack_base_or_null());
stooke marked this conversation as resolved.
Show resolved Hide resolved
}

struct GCThreadClosure : public ThreadClosure {
Expand Down
1 change: 1 addition & 0 deletions src/hotspot/share/runtime/thread.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,7 @@ class Thread: public ThreadShadow {
public:
// Stack overflow support
address stack_base() const DEBUG_ONLY(;) NOT_DEBUG({ return _stack_base; })
address stack_base_or_null() const { return _stack_base; }
stooke marked this conversation as resolved.
Show resolved Hide resolved
void set_stack_base(address base) { _stack_base = base; }
size_t stack_size() const { return _stack_size; }
void set_stack_size(size_t size) { _stack_size = size; }
Expand Down