Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak #574

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cost0much
Copy link

@cost0much cost0much commented Sep 3, 2024

Clean backport that makes TestListenerLeak more robust; already backported to 11, 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316193 needs maintainer approval

Issue

  • JDK-8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/574/head:pull/574
$ git checkout pull/574

Update a local copy of the PR:
$ git checkout pull/574
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/574/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 574

View PR using the GUI difftool:
$ git pr show -t 574

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/574.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f6be922952642f40dcf0d27b7896c9a6acdd6378 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Sep 3, 2024
@openjdk
Copy link

openjdk bot commented Sep 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Sep 3, 2024
@cost0much cost0much marked this pull request as ready for review October 9, 2024 22:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 9, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@cost0much
Copy link
Author

/approval request Improves the jfr TestListenerLeak test. Applies cleanly. Affected test passes. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Oct 9, 2024

@cost0much
8316193: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 9, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2024

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants