-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak #574
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Improves the jfr TestListenerLeak test. Applies cleanly. Affected test passes. Risk is low: the change is test code only. |
@cost0much |
@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Clean backport that makes TestListenerLeak more robust; already backported to 11, 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/574/head:pull/574
$ git checkout pull/574
Update a local copy of the PR:
$ git checkout pull/574
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/574/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 574
View PR using the GUI difftool:
$ git pr show -t 574
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/574.diff
Webrev
Link to Webrev Comment