Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261020: Wrong format parameter in create_emergency_chunk_path #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lingjun-cg
Copy link

@lingjun-cg lingjun-cg commented Nov 6, 2024

Clean backport from jdk11u.
I'd like to backport it to fix a crash like the following stack when run the testcase ' 'jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java' on host with AArch64.

===============================
Stack: [0x0000ffff8b860000,0x0000ffff8ba60000], sp=0x0000ffff8ba5da80, free space=2038k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C [libc.so.6+0x27b0c] __strlen_mte+0xc
C [libc.so.6+0x756e4] __vsnprintf_internal+0xb0
C [libc.so.6+0x7576c] vsnprintf+0x2c
V [libjvm.so+0x868134] os::vsnprintf(char*, unsigned long, char const*, std::__va_list)+0x30
V [libjvm.so+0x685ba8] jio_vsnprintf+0x34
V [libjvm.so+0x685c44] jio_snprintf+0x78
V [libjvm.so+0x5fd624] JfrEmergencyDump::build_dump_path(char const*)+0xe0
V [libjvm.so+0x61e634] JfrRepository::open_chunk(bool)+0x98
V [libjvm.so+0x61a860] JfrRecorderService::prepare_for_vm_error_rotation()+0x90
V [libjvm.so+0x61db50] JfrRecorderService::rotate(int)+0x260
V [libjvm.so+0x5fdc18] JfrEmergencyDump::on_vm_shutdown(bool)+0x264
V [libjvm.so+0x5e2210] before_exit(JavaThread*)+0x124
V [libjvm.so+0x9be134] Threads::destroy_vm()+0x1cc
V [libjvm.so+0x64901c] jni_DestroyJavaVM+0x80
C [libjli.so+0x2e44] JavaMain+0x284
C [libpthread.so.0+0x7f74] start_thread+0xd0
C [libc.so.6+0x28f9c] thread_start+0xc

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8261020 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261020: Wrong format parameter in create_emergency_chunk_path (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/602/head:pull/602
$ git checkout pull/602

Update a local copy of the PR:
$ git checkout pull/602
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/602/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 602

View PR using the GUI difftool:
$ git pr show -t 602

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/602.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2024

👋 Welcome back lingjun-cg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@lingjun-cg Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@lingjun-cg
Copy link
Author

/approval request Wrong format parameter in create_emergency_chunk_path

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@lingjun-cg
8261020: The approval request has been created successfully.

@phohensee
Copy link
Member

This needs to be a backport PR as the bot comment says. It'll probably be marked clean and not need review.

@lingjun-cg lingjun-cg changed the title 8261020: Wrong format parameter in create_emergency_chunk_path Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a Nov 7, 2024
@openjdk openjdk bot changed the title Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a 8261020: Wrong format parameter in create_emergency_chunk_path Nov 7, 2024
@openjdk
Copy link

openjdk bot commented Nov 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants