Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sophia-guo
Copy link

@sophia-guo sophia-guo commented Nov 15, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8037013 needs maintainer approval

Issue

  • JDK-8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/604/head:pull/604
$ git checkout pull/604

Update a local copy of the PR:
$ git checkout pull/604
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 604

View PR using the GUI difftool:
$ git pr show -t 604

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/604.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2024

👋 Welcome back sophia-guo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 02186906efdb581a7b4494cfd9e21f45bc76e9ed 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX Nov 15, 2024
@openjdk
Copy link

openjdk bot commented Nov 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

⚠️ @sophia-guo This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Nov 15, 2024

Webrevs

@sophia-guo
Copy link
Author

/approval request I would like to backport 8037013 to jdk8u. This is test bug. Backport is clean, risk is low.

@openjdk
Copy link

openjdk bot commented Nov 16, 2024

@sophia-guo
8037013: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant