Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: bayes_spec: A Bayesian Spectral Line Modeling Framework for Astrophysics #7112

Closed
editorialbot opened this issue Aug 17, 2024 · 22 comments
Assignees
Labels
pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 17, 2024

Submitting author: @tvwenger (Trey Wenger)
Repository: https://github.com/tvwenger/bayes_spec
Branch with paper.md (empty if default branch):
Version: v1.5.0
Editor: @ivastar
Reviewers: @ConorMacBride, @kbwestfall, @larryshamalama
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9"><img src="https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9/status.svg)](https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9)

Author instructions

Thanks for submitting your paper to JOSS @tvwenger. Currently, there isn't a JOSS editor assigned to your paper.

@tvwenger if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Aug 17, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4357/ac2f42 is OK
- 10.7717/peerj-cs.1516 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (766.7 files/s, 247863.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          20            475            910           1592
Jupyter Notebook                 4              0           8986            604
Markdown                         2             73              0            149
YAML                             6             11             21            149
reStructuredText                 4             37             63             41
TOML                             1              5              0             32
TeX                              1              1              0             28
DOS Batch                        1              8              1             26
JSON                             1              0              0             23
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            41            614           9988           2653
-------------------------------------------------------------------------------

Commit count by author:

    15	Trey Wenger

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 291

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@dfm
Copy link

dfm commented Aug 17, 2024

@tvwenger — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dfm dfm added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Aug 17, 2024
@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Astronomical échelle spectroscopy data analysis with muler
Submitting author: @gully
Handling editor: @xuanxu (Active)
Reviewers: @bmorris3, @wtgee
Similarity score: 0.7127

PySPI: A python analysis framework for INTEGRAL/SPI
Submitting author: @BjoernBiltzinger
Handling editor: @christinahedges (Retired)
Reviewers: @tohuvavohu, @dfm
Similarity score: 0.7115

MCALF: Multi-Component Atmospheric Line Fitting
Submitting author: @ConorMacBride
Handling editor: @mbobra (Active)
Reviewers: @mgalloy, @Goobley
Similarity score: 0.7100

pyradiosky: A Python package for Radio Sky Models
Submitting author: @bhazelton
Handling editor: @xuanxu (Active)
Reviewers: @pritchardn, @0xCoto
Similarity score: 0.7065

DBSP_DRP: A Python package for automated spectroscopic data reduction of DBSP data
Submitting author: @finagle29
Handling editor: @arfon (Active)
Reviewers: @crhea93, @arjunsavel
Similarity score: 0.7057

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@tvwenger
Copy link

larryshamalama would be an excellent referee, I think!

@tvwenger
Copy link

For the future editor: I am aware that JOSS has substantial "scholarly effort" criteria, and that the age of this repository might suggest that it does not meet these criteria. I wanted to give a bit of context for the project to justify its significant scholarly effort.

bayes_spec has been developed over the past ~18 months, originally forming the foundation of a specific model:
https://github.com/tvwenger/amoeba2

Given the general-use applicability of this Bayesian spectral modeling framework, the core framework from amoeba2 was split into bayes_spec so that it could be extended to any user-specified model.

There are now several models implemented in the bayes_spec framework, and the applications of each are being prepared for astronomy journals.
https://github.com/tvwenger/bayes_cn_hfs
https://github.com/tvwenger/amoeba2
https://github.com/tvwenger/bayes_yplus
https://github.com/tvwenger/caribou_hi

It would be great to be able to point to the JOSS paper for bayes_spec in each of these astronomy papers!

@ivastar
Copy link

ivastar commented Aug 28, 2024

@editorialbot assign @ivastar as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @ivastar is now the editor

@ivastar ivastar removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Aug 28, 2024
@ivastar
Copy link

ivastar commented Aug 28, 2024

Hi @tvwenger! I will be the editor for this submission. I will be looking for reviewers in the next week or so. Thank you for the suggestion above!

@ivastar
Copy link

ivastar commented Sep 7, 2024

@editorialbot add @ConorMacBride as reviewer

@editorialbot
Copy link
Collaborator Author

@ConorMacBride added to the reviewers list!

@openjournals openjournals deleted a comment from editorialbot Sep 7, 2024
@ivastar
Copy link

ivastar commented Sep 7, 2024

@editorialbot add @larryshamalama as reviewer

@ivastar
Copy link

ivastar commented Sep 7, 2024

@editorialbot add @kbwestfall as reviewer

@editorialbot
Copy link
Collaborator Author

@kbwestfall added to the reviewers list!

@ivastar
Copy link

ivastar commented Sep 7, 2024

@editorialbot add @larryshamalama as reviewer

@editorialbot
Copy link
Collaborator Author

@larryshamalama added to the reviewers list!

@ivastar
Copy link

ivastar commented Sep 7, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7201.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

4 participants