Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection Management and Arrow #165

Merged
merged 22 commits into from
May 21, 2024
Merged

Connection Management and Arrow #165

merged 22 commits into from
May 21, 2024

Conversation

brancengregory
Copy link
Member

@brancengregory brancengregory commented Apr 15, 2024

Fixes connection issues with simpler strategy; adds basic arrow support; adds github related lines to DESCRIPTION file; replaces stringr with slightly faster stringi functions

@brancengregory
Copy link
Member Author

@andrewjbe This would be a minor version change

@brancengregory brancengregory changed the title Fixes connection issues with simpler strategy; adds basic arrow support; adds github related lines to DESCRIPTION file; replaces stringr with slightly faster stringi functions Connection Management and Arrow Apr 15, 2024
@brancengregory
Copy link
Member Author

/document

@andrewjbe
Copy link
Collaborator

The only change I want to make is to re-run the tests using the github actions connection info and then re-accept the snapshots, so that they'll match when github actions does the tests. But I need the password, and can't find it in Bitwarden

@andrewjbe
Copy link
Collaborator

I actually think this is probably not the best solution; we just need to give the github actions role in our DB access to all the tables and stuff. But this will work for now

Copy link
Collaborator

@andrewjbe andrewjbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our next step for {ojodb} is fixing up ojo_collect() so that it works with .source = "gcs", or at least adding more helpful error messages for that. We should also probably add some tests to ensure equivalency (or rough equivalency) between the results of the two .source args

@brancengregory brancengregory merged commit 8775b8b into main May 21, 2024
7 checks passed
@brancengregory brancengregory deleted the dev branch May 21, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants