-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection Management and Arrow #165
Conversation
@andrewjbe This would be a minor version change |
/document |
The only change I want to make is to re-run the tests using the github actions connection info and then re-accept the snapshots, so that they'll match when github actions does the tests. But I need the password, and can't find it in Bitwarden |
I actually think this is probably not the best solution; we just need to give the github actions role in our DB access to all the tables and stuff. But this will work for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think our next step for {ojodb} is fixing up ojo_collect() so that it works with .source = "gcs"
, or at least adding more helpful error messages for that. We should also probably add some tests to ensure equivalency (or rough equivalency) between the results of the two .source
args
Fixes connection issues with simpler strategy; adds basic arrow support; adds github related lines to DESCRIPTION file; replaces stringr with slightly faster stringi functions