Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFX-Mentorship-Fall: StatefulSet support volume claim resize #905

Closed
tianzichenone opened this issue Feb 17, 2022 · 5 comments · Fixed by #1674
Closed

LFX-Mentorship-Fall: StatefulSet support volume claim resize #905

tianzichenone opened this issue Feb 17, 2022 · 5 comments · Fixed by #1674
Assignees
Milestone

Comments

@tianzichenone
Copy link

tianzichenone commented Feb 17, 2022

What would you like to be added:
Auto resize PVC capacity when updating volume claim template in Advanced StatefulSet and CloneSet.

And should consider the following things:

  • How to check StorageClass(CSI Driver) support resize capacity of PV?
  • How to let users know whether the resize is successful?
  • Should we rebuild Pod (and PVC) if the CSI Driver does not support resize PV (especially for CloneSet)?
  • Align with the design of upstream: KEP-0661: StatefulSet volume resize kubernetes/enhancements#3412

Why is this needed:
When we want to expand all PVCs of StatefulSet or CloneSet , we should update PVCs manually.
When we update capacity in volume claim template, the newly created Pods will use updated capacity, but the old Pods not, this confusing the user.

@FillZpp
Copy link
Member

FillZpp commented Feb 22, 2022

@tianzichenone Thanks. If upstream is working on this kubernetes/enhancements#2842 , we'd better wait for it and then rebase into Kruise, to make sure the behavior is consistent with upstream.

@zmberg zmberg added the kind/good-idea Good Idea label Feb 20, 2023
@veophi veophi changed the title [feature request] Support auto resize pvc capacity in statefulset LFX-Mentorship-Fall: CloneSet&StatefulSet support volume claim resize Jul 27, 2023
@y-ykcir
Copy link
Contributor

y-ykcir commented Aug 1, 2023

@veophi @zmberg Hi, is this issue an LFX Mentorship Fall issue? I haven't seen any related links to this issue in term3

@ABNER-1
Copy link
Member

ABNER-1 commented Mar 28, 2024

Please consider assigning this issue to me.

@zmberg
Copy link
Member

zmberg commented Mar 28, 2024

/assign @ABNER-1

@ABNER-1
Copy link
Member

ABNER-1 commented May 29, 2024

A new proposal of upstream: kubernetes/enhancements#4651

@zmberg zmberg changed the title LFX-Mentorship-Fall: CloneSet&StatefulSet support volume claim resize LFX-Mentorship-Fall: StatefulSet support volume claim resize Jul 25, 2024
@zmberg zmberg modified the milestones: 1.7, 1.8 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants