Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi version #254

Open
Pantelispanka opened this issue Oct 21, 2022 · 11 comments
Open

pypi version #254

Pantelispanka opened this issue Oct 21, 2022 · 11 comments

Comments

@Pantelispanka
Copy link

Will there ever be a pypi package for the module ? If you are planning for that i can offer some help! Thanks!

@peastman
Copy link
Member

I hope so! We first need PyPI packages for OpenMM, which PDBFixer depends on. We're investigating that right now: openmm/openmm#3796. If you want to help, that would be fantastic.

@minhuanli
Copy link

Hi, I want to do a quick follow up on this issue.

Why don't we make PDBFixer a PyPI package alone? The main OpenMM module seems tricky because of the cuda stuff, but you could assume people have already installed the OpenMM before they need PDBFixer? Just save people from downloading the whole repo before installation.

@peastman
Copy link
Member

peastman commented Feb 7, 2023

What would be the use case for that? If you've already installed OpenMM with conda, what's the benefit of installing PDBFixer with pip instead of conda?

@minhuanli
Copy link

I am not sure if I take it correctly. Do you mean PDBFixer itself can be installed by conda? I didn't see that in the installation tutorials

@minhuanli
Copy link

One common case for me is that, I have installed OpenMM according to the official document:

conda install -c conda-forge openmm cudatoolkit=xx.x

Then I realize that I also need PDBfixer to preprocess PDB files.

It would be great if I could simply do pip install PDBFixer instead of git clone the whole repo and run pip install .

@peastman
Copy link
Member

peastman commented Feb 7, 2023

Correct. This will install it, including all dependencies.

conda install -c conda-forge pdbfixer

We should add that to the README.

@minhuanli
Copy link

Got it! That makes much more sense now. Yes, should add this to the README. Thank you for the clarification.

@peastman
Copy link
Member

peastman commented Feb 7, 2023

The updated instructions are in #265.

@recursingfeynman
Copy link

If pdbfixer were on pypi it would be convenient to install it along with dependencies via poetry. Poetry can also handle dependencies like conda, but unlike it it shows better performance

@k9cdt
Copy link

k9cdt commented Sep 24, 2024

Now that OpenMM has been available on PyPI since May 10, 2024, I think it’s a good time to bring this issue up again.

Uploading pdbfixer to PyPI would really help those of us using it as a dependency in our own projects. Currently, any package on PyPI can’t depend on something that isn’t also on PyPI (which I get, even though it’s a bit limiting).

PEP 725 is still a draft, so it looks like we’ll have to wait before GitHub repositories can be used as dependencies.

@peastman
Copy link
Member

The current PyPI builds for OpenMM are just a proof of concept and shouldn't be relied on. I'm hoping in the future we'll have proper builds that are fully tested and supported. We have a ways to go before that can happen though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants