-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDBFixer not writing out complete CONECT records for downloaded Templates #297
Comments
Update: This code does work for Tyrosine -> Phosphotyrosine mutations! 🎉 When I take the same starting file above and run the following code:
The CONECT records and visualization for the output are both consistent with my expectations:
Visualized PTR residue in Pymol: This led me to wonder if there was an issue with the SEP template being downloaded and used, so I went and downloaded from the ligand-expo, specifically the "ideal coordinates" version. Weirdly, the 'ideal coordinates" version of SEP (
Summary points:
Edit: Added image of "as expected" PTR residue output |
Strange, I have no idea why it would work for PTR but not SEP. The file it downloads is Line 402 in 92044f3
where I'll take a look and see if I can figure out what's happening. |
I think the problem is in these lines: Lines 579 to 583 in 92044f3
|
The fix is in #298. Give it a try and see if it works now. |
Does the thumbs up mean you checked and it works, or just that you're going to test? Emoji can be unclear. 😀 |
Hah sorry for the lack of clarity - that was just an "acknowledgement" that I've seen it (had to step out for meetings all afternoon afterwards). Repeating tests with #298 now - will update! |
And I bet you're wondering why I posted an emoji of someone opening their mouth to have dental work done! Or are they about to bite down on a carrot? Really hard to tell. |
Can't wait till the day github lets us insert gifs into posts - then we'll have even more ways to create confusion (sorry again!) |
I'll cross post into #298 but looks like the fix worked! I ran the following commands:
And the visualization appears as expected! The CONECT records are more explicitly complete as well, which is what I would have expected:
I can also confirm that the TYR -> PTR still works as before with no issues. Huzzah! |
Thanks! |
With #296 being merged in, I wanted to revisit trying to model in a serine to phosphoserine mutation. For OpenMM simulations, my understanding is that it's the CONECT records should be written out for the entirety of a non-standard amino acid to ensure appropriate template matching occurs with a given forcefield (please correct me if I'm wrong!). However, it seems like the full CONECT records for a non-standard SEP residue aren't written out. Detailed below:
Starting with the following starting file:
test-ser-noPhos.pdb.zip
I downloaded the latest version of this release from github and ran the following code:
When I visualize the structure, I noticed that, as happening in #284, the atoms were added to the PDB file, but the CONECT records weren't being explicitly added for the phosphate group. The current output for the CONECT records at the bottom of the
test-sep-output.pdb
is:Visualized below is the SEP residue in pymol, the atoms are present (pink dots) but aren't being rendered with bonds due to lack of CONECT records:
What I would expect for a complete set of CONECT records for SEP would be something like this:
Which yields this in Pymol:
This might just be a point of clarification for me I suppose - should I expect complete CONECT records written out for a non-standard residue? If not, then I guess this is expected behavior, but I was under the impression that I would want the full set of a CONECT records for a residue like SEP since the phosphate group are written out as
HETATM
.The text was updated successfully, but these errors were encountered: