Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Port modal registrations to use the modal system #1344

Merged
merged 1 commit into from
Oct 15, 2024
Merged

(refactor) Port modal registrations to use the modal system #1344

merged 1 commit into from
Oct 15, 2024

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR ports over some left over modal registrations to use the modal system instead of the legacy extension modal registry. It also removes an unused modal registration from the Appointments app routes registry.

Screenshots

Related Issue

Other

@denniskigen
(refactor) Port modal registrations to use the modal system
36eb693 
This PR ports over some left over modal registrations to use the modal system instead of the legacy extension modal registry. It also removes an [unused](https://github.com/search?q=org:openmrs+check-in-appointment-modal&type=code) modal registration from
the Appointments app routes registry.
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 6.49 MB

ℹ️ View Unchanged
Filename Size
packages/esm-active-visits-app/dist/106.js 8.63 kB
packages/esm-active-visits-app/dist/130.js 393 kB
packages/esm-active-visits-app/dist/233.js 3.37 kB
packages/esm-active-visits-app/dist/271.js 800 B
packages/esm-active-visits-app/dist/316.js 42.9 kB
packages/esm-active-visits-app/dist/319.js 712 B
packages/esm-active-visits-app/dist/325.js 3.09 kB
packages/esm-active-visits-app/dist/443.js 6.98 kB
packages/esm-active-visits-app/dist/460.js 824 B
packages/esm-active-visits-app/dist/574.js 615 B
packages/esm-active-visits-app/dist/586.js 53.5 kB
packages/esm-active-visits-app/dist/6.js 26.2 kB
packages/esm-active-visits-app/dist/644.js 800 B
packages/esm-active-visits-app/dist/725.js 643 B
packages/esm-active-visits-app/dist/757.js 731 B
packages/esm-active-visits-app/dist/784.js 2.63 kB
packages/esm-active-visits-app/dist/788.js 628 B
packages/esm-active-visits-app/dist/807.js 959 B
packages/esm-active-visits-app/dist/814.js 3.04 kB
packages/esm-active-visits-app/dist/833.js 765 B
packages/esm-active-visits-app/dist/879.js 3.02 kB
packages/esm-active-visits-app/dist/967.js 611 B
packages/esm-active-visits-app/dist/main.js 81.9 kB
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.32 kB
packages/esm-appointments-app/dist/130.js 393 kB
packages/esm-appointments-app/dist/171.js 223 B
packages/esm-appointments-app/dist/198.js 250 kB
packages/esm-appointments-app/dist/2.js 2.23 kB
packages/esm-appointments-app/dist/265.js 1.79 kB
packages/esm-appointments-app/dist/269.js 7.38 kB
packages/esm-appointments-app/dist/271.js 2.41 kB
packages/esm-appointments-app/dist/319.js 2.27 kB
packages/esm-appointments-app/dist/325.js 3.08 kB
packages/esm-appointments-app/dist/372.js 2.57 kB
packages/esm-appointments-app/dist/385.js 31.3 kB
packages/esm-appointments-app/dist/440.js 16.6 kB
packages/esm-appointments-app/dist/460.js 2.46 kB
packages/esm-appointments-app/dist/501.js 7.02 kB
packages/esm-appointments-app/dist/574.js 2.02 kB
packages/esm-appointments-app/dist/581.js 9.03 kB
packages/esm-appointments-app/dist/591.js 16.8 kB
packages/esm-appointments-app/dist/644.js 2.41 kB
packages/esm-appointments-app/dist/711.js 129 kB
packages/esm-appointments-app/dist/757.js 2.39 kB
packages/esm-appointments-app/dist/784.js 2.62 kB
packages/esm-appointments-app/dist/788.js 2.02 kB
packages/esm-appointments-app/dist/807.js 2.65 kB
packages/esm-appointments-app/dist/833.js 2.37 kB
packages/esm-appointments-app/dist/903.js 879 B
packages/esm-appointments-app/dist/main.js 396 kB
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.56 kB
packages/esm-bed-management-app/dist/130.js 393 kB
packages/esm-bed-management-app/dist/148.js 1.22 kB
packages/esm-bed-management-app/dist/169.js 6.98 kB
packages/esm-bed-management-app/dist/271.js 671 B
packages/esm-bed-management-app/dist/319.js 786 B
packages/esm-bed-management-app/dist/325.js 3.09 kB
packages/esm-bed-management-app/dist/339.js 50.2 kB
packages/esm-bed-management-app/dist/455.js 26.5 kB
packages/esm-bed-management-app/dist/460.js 671 B
packages/esm-bed-management-app/dist/501.js 7.03 kB
packages/esm-bed-management-app/dist/542.js 395 B
packages/esm-bed-management-app/dist/574.js 672 B
packages/esm-bed-management-app/dist/591.js 16.8 kB
packages/esm-bed-management-app/dist/644.js 671 B
packages/esm-bed-management-app/dist/757.js 814 B
packages/esm-bed-management-app/dist/766.js 113 kB
packages/esm-bed-management-app/dist/784.js 2.63 kB
packages/esm-bed-management-app/dist/788.js 671 B
packages/esm-bed-management-app/dist/807.js 671 B
packages/esm-bed-management-app/dist/833.js 671 B
packages/esm-bed-management-app/dist/main.js 3.87 kB
packages/esm-bed-management-app/dist/openmrs-esm-bed-management-app.js 3.25 kB
packages/esm-patient-list-management-app/dist/130.js 393 kB
packages/esm-patient-list-management-app/dist/233.js 3.38 kB
packages/esm-patient-list-management-app/dist/271.js 1.57 kB
packages/esm-patient-list-management-app/dist/319.js 1.51 kB
packages/esm-patient-list-management-app/dist/325.js 3.09 kB
packages/esm-patient-list-management-app/dist/37.js 12.5 kB
packages/esm-patient-list-management-app/dist/443.js 6.98 kB
packages/esm-patient-list-management-app/dist/455.js 58.1 kB
packages/esm-patient-list-management-app/dist/460.js 1.71 kB
packages/esm-patient-list-management-app/dist/574.js 1.34 kB
packages/esm-patient-list-management-app/dist/591.js 16.9 kB
packages/esm-patient-list-management-app/dist/644.js 1.57 kB
packages/esm-patient-list-management-app/dist/658.js 102 kB
packages/esm-patient-list-management-app/dist/757.js 1.62 kB
packages/esm-patient-list-management-app/dist/784.js 2.63 kB
packages/esm-patient-list-management-app/dist/788.js 1.33 kB
packages/esm-patient-list-management-app/dist/807.js 1.84 kB
packages/esm-patient-list-management-app/dist/814.js 3.05 kB
packages/esm-patient-list-management-app/dist/833.js 1.59 kB
packages/esm-patient-list-management-app/dist/main.js 162 kB
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js 3.3 kB
packages/esm-patient-registration-app/dist/130.js 393 kB
packages/esm-patient-registration-app/dist/169.js 6.71 kB
packages/esm-patient-registration-app/dist/2.js 2.24 kB
packages/esm-patient-registration-app/dist/250.js 526 B
packages/esm-patient-registration-app/dist/271.js 2.48 kB
packages/esm-patient-registration-app/dist/319.js 2.38 kB
packages/esm-patient-registration-app/dist/325.js 3.09 kB
packages/esm-patient-registration-app/dist/371.js 547 B
packages/esm-patient-registration-app/dist/372.js 2.57 kB
packages/esm-patient-registration-app/dist/460.js 2.46 kB
packages/esm-patient-registration-app/dist/501.js 7.03 kB
packages/esm-patient-registration-app/dist/574.js 2.09 kB
packages/esm-patient-registration-app/dist/591.js 16.8 kB
packages/esm-patient-registration-app/dist/644.js 2.48 kB
packages/esm-patient-registration-app/dist/662.js 453 B
packages/esm-patient-registration-app/dist/700.js 69.8 kB
packages/esm-patient-registration-app/dist/757.js 2.51 kB
packages/esm-patient-registration-app/dist/784.js 2.63 kB
packages/esm-patient-registration-app/dist/788.js 2.09 kB
packages/esm-patient-registration-app/dist/807.js 2.71 kB
packages/esm-patient-registration-app/dist/833.js 2.36 kB
packages/esm-patient-registration-app/dist/879.js 3.03 kB
packages/esm-patient-registration-app/dist/998.js 67.2 kB
packages/esm-patient-registration-app/dist/main.js 137 kB
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.34 kB
packages/esm-patient-search-app/dist/130.js 393 kB
packages/esm-patient-search-app/dist/233.js 3.37 kB
packages/esm-patient-search-app/dist/271.js 920 B
packages/esm-patient-search-app/dist/319.js 861 B
packages/esm-patient-search-app/dist/325.js 3.09 kB
packages/esm-patient-search-app/dist/335.js 25.1 kB
packages/esm-patient-search-app/dist/443.js 6.98 kB
packages/esm-patient-search-app/dist/460.js 939 B
packages/esm-patient-search-app/dist/574.js 742 B
packages/esm-patient-search-app/dist/591.js 16.8 kB
packages/esm-patient-search-app/dist/634.js 52 kB
packages/esm-patient-search-app/dist/644.js 920 B
packages/esm-patient-search-app/dist/757.js 888 B
packages/esm-patient-search-app/dist/784.js 2.63 kB
packages/esm-patient-search-app/dist/788.js 736 B
packages/esm-patient-search-app/dist/807.js 1.04 kB
packages/esm-patient-search-app/dist/814.js 3.05 kB
packages/esm-patient-search-app/dist/833.js 877 B
packages/esm-patient-search-app/dist/main.js 77.9 kB
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.29 kB
packages/esm-service-queues-app/dist/130.js 393 kB
packages/esm-service-queues-app/dist/169.js 6.98 kB
packages/esm-service-queues-app/dist/199.js 1.36 kB
packages/esm-service-queues-app/dist/2.js 2.23 kB
packages/esm-service-queues-app/dist/236.js 5.84 kB
packages/esm-service-queues-app/dist/271.js 4.6 kB
packages/esm-service-queues-app/dist/282.js 8.97 kB
packages/esm-service-queues-app/dist/319.js 4.35 kB
packages/esm-service-queues-app/dist/325.js 3.09 kB
packages/esm-service-queues-app/dist/366.js 7.86 kB
packages/esm-service-queues-app/dist/372.js 2.57 kB
packages/esm-service-queues-app/dist/392.js 7.85 kB
packages/esm-service-queues-app/dist/460.js 4.82 kB
packages/esm-service-queues-app/dist/501.js 7.03 kB
packages/esm-service-queues-app/dist/574.js 3.88 kB
packages/esm-service-queues-app/dist/591.js 16.8 kB
packages/esm-service-queues-app/dist/6.js 1.75 kB
packages/esm-service-queues-app/dist/60.js 1.82 kB
packages/esm-service-queues-app/dist/604.js 6.96 kB
packages/esm-service-queues-app/dist/644.js 4.6 kB
packages/esm-service-queues-app/dist/665.js 160 kB
packages/esm-service-queues-app/dist/670.js 10.1 kB
packages/esm-service-queues-app/dist/727.js 8.1 kB
packages/esm-service-queues-app/dist/748.js 116 kB
packages/esm-service-queues-app/dist/752.js 1.62 kB
packages/esm-service-queues-app/dist/757.js 4.74 kB
packages/esm-service-queues-app/dist/760.js 7.13 kB
packages/esm-service-queues-app/dist/784.js 2.63 kB
packages/esm-service-queues-app/dist/788.js 3.89 kB
packages/esm-service-queues-app/dist/800.js 1.68 kB
packages/esm-service-queues-app/dist/807.js 5.17 kB
packages/esm-service-queues-app/dist/818.js 2.55 kB
packages/esm-service-queues-app/dist/828.js 1.39 kB
packages/esm-service-queues-app/dist/833.js 4.5 kB
packages/esm-service-queues-app/dist/911.js 7.76 kB
packages/esm-service-queues-app/dist/940.js 21.4 kB
packages/esm-service-queues-app/dist/main.js 276 kB
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.31 kB
packages/esm-ward-app/dist/109.js 344 B
packages/esm-ward-app/dist/125.js 5.73 kB
packages/esm-ward-app/dist/126.js 32.2 kB
packages/esm-ward-app/dist/130.js 393 kB
packages/esm-ward-app/dist/146.js 709 B
packages/esm-ward-app/dist/15.js 482 B
packages/esm-ward-app/dist/161.js 35.5 kB
packages/esm-ward-app/dist/169.js 6.97 kB
packages/esm-ward-app/dist/2.js 2.23 kB
packages/esm-ward-app/dist/269.js 829 B
packages/esm-ward-app/dist/325.js 3.08 kB
packages/esm-ward-app/dist/348.js 349 B
packages/esm-ward-app/dist/372.js 2.56 kB
packages/esm-ward-app/dist/466.js 393 B
packages/esm-ward-app/dist/500.js 5 kB
packages/esm-ward-app/dist/501.js 7.02 kB
packages/esm-ward-app/dist/53.js 11.4 kB
packages/esm-ward-app/dist/557.js 486 B
packages/esm-ward-app/dist/559.js 326 B
packages/esm-ward-app/dist/574.js 1.47 kB
packages/esm-ward-app/dist/577.js 18 kB
packages/esm-ward-app/dist/591.js 16.8 kB
packages/esm-ward-app/dist/659.js 9.99 kB
packages/esm-ward-app/dist/701.js 3.49 kB
packages/esm-ward-app/dist/749.js 8.18 kB
packages/esm-ward-app/dist/767.js 648 B
packages/esm-ward-app/dist/784.js 2.62 kB
packages/esm-ward-app/dist/908.js 1.97 kB
packages/esm-ward-app/dist/922.js 9.37 kB
packages/esm-ward-app/dist/940.js 21.4 kB
packages/esm-ward-app/dist/969.js 202 B
packages/esm-ward-app/dist/main.js 68.5 kB
packages/esm-ward-app/dist/openmrs-esm-ward-app.js 3.29 kB

compressed-size-action

chibongho
chibongho approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@denniskigen
Copy link
Member Author

Thanks, @chibongho!

@denniskigen denniskigen merged commit 6f337de into main Oct 15, 2024
6 checks passed
@denniskigen denniskigen deleted the refactor/port-modals branch October 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibongho chibongho chibongho approved these changes

@mogoodrich mogoodrich Awaiting requested review from mogoodrich

@donaldkibet donaldkibet Awaiting requested review from donaldkibet

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskigen @chibongho