(feat) O3-2255: Using REST endpoint to fetch address template and updated the tests for the address component #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -42.5 kB (-2%) Total Size: 2.14 MB
ℹ️ View Unchanged
|
ibacher
reviewed
Jul 26, 2023
| setValidationSchema((validationSchema) => validationSchema.concat(addressValidationSchema)); | ||
| } | ||
| }, [inEditMode, addressTemplate, initialAddressFieldValues]); | ||
| // useEffect(() => { |
There was a problem hiding this comment.
Hi @ibacher !
This brings to another question.
Do we need the regex validation from the address template to work on the frontend?
Thanks!
There was a problem hiding this comment.
@vasharma05 Probably eventually, but it's not the highest priority.
|
Will the value for |
|
@denniskigen It looks like we're properly pulling defaults from the address template, so if someone puts a value in there, it will be the default, but we should be able to unset it. |
|
Thank you @ibacher for the strict typings! Regarding the default @denniskigen, @gracepotma filed this ticket to remove the dev3. As I suggested before as well in the coffee break, I believe we should have a default value in the reference application, let not be Cambodia, but something so that the end user is aware that we have the defaults functioning in the address template. What do you say about this @gracepotma ? |
ibacher
approved these changes
Aug 8, 2023
ibacher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR updates the address component in the patient registration form to fetch the address configuration using the REST endpoint
/es/rest/v1/addresstemplate. This improves the label provided for the different fields on the form and the translation is also handled on the backend itself.Alongside, the test cases were updated with the new endpoint's results as mock and added new test suite for the address search component.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-2255
Other
None.