HTML-841: Errors with Form Namespace and Path #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogoodrich
commented
Apr 3, 2024
| @@ -86,32 +92,7 @@ public Drug getAnswerDrug() { | |||
| public void setAnswerDrug(Drug answerDrug) { | |||
| this.answerDrug = answerDrug; | |||
| } | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
Just removed this as it was deprecated and not used anywhere as far as I could tell
mseaton
reviewed
Apr 3, 2024
|
|
||
| // if any one of the obs group components have a control id, and it matches the obs control id, just return 1000 to force a match | ||
| if (obsGroupComponent.getControlId() != null | ||
| && obsGroupComponent.getControlId().equals(HtmlFormEntryUtil.getControlId(obs))) { |
There was a problem hiding this comment.
Defer to you as to whether this 1000 value is sufficiently safe, vs. (eg) max value integer
There was a problem hiding this comment.
We used -1000 for the max negative, so just using this for consistency. I'm pretty sure it sufficiently safe.
mseaton
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/HTML-
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
No? -> read here on how to squash multiple commits into one
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master