Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPORT-906: Add pagination support to ReportRequest read methods #251

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

pwargulak
Copy link
Contributor

Summary

This change extends ReportService with new method getReportsWithPagination used to read ReportRequests for specific report, dates, statuses paginated for performance gains.
It was done as part of making of O3 Reports Admin pages.

See the related issue.

Issue

https://openmrs.atlassian.net/browse/REPORT-906

@pwargulak
Copy link
Contributor Author

pwargulak commented Mar 28, 2024

@djazayeri @mseaton
I had to move #249 to this one.

The previous PR was already marked as "OK" by @mseaton, @djazayeri could you take a look at this one?

@sherrif10
Copy link
Member

Hello @ibacher @dkayiwa @pwargulak is this ready to be merged ?

@druchniewicz
Copy link

druchniewicz commented Dec 23, 2024

@ibacher @mseaton @dkayiwa @djazayeri

we would like to get back to this and make the code ready for merging. We applied previous remarks from code review. Can you take a look at this once again?
This PR and openmrs/openmrs-module-reportingrest#33 are related to each other and together constitute backend for Reports page in O3 UI - openmrs/openmrs-esm-admin-tools#45 (this UI PR has to be adapted after merging backend PRs)
CC: @pwargulak

@mseaton mseaton merged commit d37011a into openmrs:master Jan 2, 2025
0 of 16 checks passed
@mseaton
Copy link
Member

mseaton commented Jan 2, 2025

Thanks @druchniewicz and @pwargulak - sorry for the long time this took to get merged. It looks great and I've gone ahead and merged it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants