Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset reasoner #56

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Reset reasoner #56

merged 5 commits into from
Nov 14, 2023

Conversation

bowen-xu
Copy link
Collaborator

@maxeeem could you review the changes? I guess some tests are needed.

image

The reset() method of class Reasoner is implemented. The command ''reset can be used to reset the reasoner in Console.

@bowen-xu bowen-xu added the enhancement New feature or request label Nov 14, 2023
@bowen-xu bowen-xu requested a review from maxeeem November 14, 2023 03:46
@bowen-xu bowen-xu self-assigned this Nov 14, 2023
@bowen-xu bowen-xu linked an issue Nov 14, 2023 that may be closed by this pull request
@maxeeem
Copy link
Collaborator

maxeeem commented Nov 14, 2023

I'll take a look. Old code in rule_map_two_premises called reset() which is probably causing some issues.

@maxeeem
Copy link
Collaborator

maxeeem commented Nov 14, 2023

@bowen-xu I updated the tests to use reset() and as an added bonus, all tests now run 5x faster! because we no longer have to construct the whole Reasoner object on each run! Great Work!

147 test now passing compared to 140 before :)

@maxeeem maxeeem merged commit 2b96160 into dev Nov 14, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Reset reasoner
2 participants