Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce-number-of-spatial-queries #2045

Closed
wants to merge 2 commits into from
Closed

Conversation

michmuel
Copy link
Collaborator

closes #2037

@michmuel michmuel self-assigned this Aug 29, 2024
@michmuel michmuel marked this pull request as draft August 29, 2024 06:26
@vvmruder
Copy link
Collaborator

@michmuel Just a quick pointer: The amount of requests was intrduced to be able to handle geometrycollections. I think this is still a case because some topics may encapsulate all three simple type kinds (point, line, polygon) in one table.

@michmuel
Copy link
Collaborator Author

@vvmruder That part is not removed. The handling of geometry collections results in only one db query as well. The issue here is that the retrieval of the legend entries requires for each law status an additional spatial query.

Copy link
Collaborator

@svamaa svamaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finally managed to test the branch locally with our adjustments in BS.
Seems like the json extract did not get faster, but slightly slower for the very large parcel.
However, on top of collecting the legend entries from the db, we have to filter them again. I guess this is what dissolves the time win from this branch on standard pyramid_oereb.

@svamaa svamaa closed this Oct 17, 2024
@svamaa svamaa deleted the repeated-spatial-queries branch October 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load geometries more efficiently
3 participants