Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration test for the unbiased counterfactual prediction #8

Open
3 tasks
clarkliming opened this issue Mar 13, 2024 · 1 comment
Open
3 tasks

Comments

@clarkliming
Copy link
Collaborator

clarkliming commented Mar 13, 2024

related to #7

The feature is large so better to split it here.
It is dependent on #7 but already can create some suitable test cases as part of the integration tests
the unit test on the function side should be covered in #7, but some tests with data and expected input should be provided here.

mockery can be used to provide a suitable predictions (instead of playing around the raw data)

  • add integration test for the feature
    • basic tests with some fake data like iris, make sure the result is "static" (does not change, use some snapshot values)
    • play with the predictions, e.g. manually create some "biased prediction in different stratums" and check if they are still biased in the provided result
@clarkliming clarkliming added this to the first CRAN release milestone Apr 10, 2024
@clarkliming clarkliming changed the title add unit test for the unbiased counterfactual prediction add integration test for the unbiased counterfactual prediction May 14, 2024
@mbannick
Copy link
Collaborator

mbannick commented Jan 2, 2025

@clarkliming please see the tests that I wrote in bugfix/prediction-unbiasedness in #55 using the negative binomial working model. It might cover these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants