Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NextBestList and subclasses #857

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Puzzled-Face
Copy link
Collaborator

Pull Request

Fixes #nnn

@Puzzled-Face Puzzled-Face linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Unit Tests Summary

    1 files     45 suites   2m 31s ⏱️
1 349 tests 1 191 ✅ 157 💤 1 ❌
6 581 runs  6 381 ✅ 197 💤 3 ❌

For more details on these failures, see this check.

Results for commit a3eba90.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Rules-methods 👶 $+0.03$ NextBestList_fails_gracefully_with_bad_input
Rules-methods 👶 $+0.34$ nextBest_NextBestMax_works_correctly
Rules-methods 👶 $+0.31$ nextBest_NextBestMin_works_correctly

Results for commit b270eb9

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for "smallest/largest next best" dose
1 participant