Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal non-convergence if theta_vcov is not positive definite #468

Merged
merged 5 commits into from
Sep 21, 2024

Conversation

danielinteractive
Copy link
Collaborator

closes #442

Copy link
Contributor

github-actions bot commented Sep 21, 2024

Unit Tests Summary

    1 files     46 suites   27s ⏱️
  514 tests   474 ✅ 40 💤 0 ❌
1 974 runs  1 925 ✅ 49 💤 0 ❌

Results for commit fa39600.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tmb 👶 $+0.01$ h_mmrm_tmb_check_conv_warns_if_theta_vcov_is_not_positive_definite
tmb 👶 $+0.01$ h_mmrm_tmb_check_conv_warns_if_theta_vcov_is_not_symmetric
tmb 👶 $+0.01$ h_mmrm_tmb_check_conv_warns_if_theta_vcov_is_numerically_singular

Results for commit b536320

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ----------------------------
R/between-within.R             59       0  100.00%
R/component.R                  69       0  100.00%
R/cov_struct.R                 97       1  98.97%   407
R/empirical.R                   7       0  100.00%
R/fit.R                       229       3  98.69%   420, 481, 511
R/interop-car.R               130       1  99.23%   9
R/interop-emmeans.R            51       0  100.00%
R/interop-parsnip.R            59       1  98.31%   12
R/kenwardroger.R               92       2  97.83%   41, 63
R/mmrm-methods.R              140       0  100.00%
R/residual.R                    8       0  100.00%
R/satterthwaite.R             116      12  89.66%   238-249
R/skipping.R                    8       0  100.00%
R/testing.R                    64       4  93.75%   29, 31, 80, 82
R/tidiers.R                    72       2  97.22%   46-47
R/tmb-methods.R               294       3  98.98%   162, 306-307
R/tmb.R                       305       1  99.67%   206
R/utils-formula.R              27       0  100.00%
R/utils-nse.R                  16       0  100.00%
R/utils.R                     212      12  94.34%   279-289, 449, 478
R/zzz.R                        72      26  63.89%   7-26, 59-64, 94, 122, 142
src/chol_cache.h               63       0  100.00%
src/covariance.h              101       1  99.01%   177
src/derivatives.h             126       0  100.00%
src/empirical.cpp              72       0  100.00%
src/exports.cpp                47       0  100.00%
src/jacobian.cpp               47       1  97.87%   54
src/kr_comp.cpp                56       0  100.00%
src/mmrm.cpp                   76       0  100.00%
src/predict.cpp                93       0  100.00%
src/test-chol_cache.cpp        58       5  91.38%   9, 18, 26, 55, 62
src/test-covariance.cpp       123       5  95.93%   9, 29, 40, 61, 72
src/test-derivatives.cpp      108       7  93.52%   44, 53, 62, 85, 94, 106, 124
src/test-utils.cpp            195       7  96.41%   9, 16, 24, 34, 44, 57, 119
src/testthat-helpers.h         15       5  66.67%   36-37, 41, 50, 53
src/utils.h                    78       0  100.00%
TOTAL                        3385      99  97.08%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/tmb.R          +4       0  +0.00%
TOTAL            +4       0  +0.00%

Results for commit: fa39600

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@danielinteractive danielinteractive merged commit cca007d into main Sep 21, 2024
23 of 24 checks passed
@danielinteractive danielinteractive deleted the 442_pos_def_check branch September 21, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add positive definiteness check of theta_vcov to h_mmrm_tmb_check_conv()
1 participant