472: fix TMB option warning

[danielinteractive]

closes #472

[danielinteractive]

@kaskr @luwidmer if you can have quick look that would be great, thank you 😃

[github-actions]

Unit Tests Summary

    1 files     46 suites   26s ⏱️
  515 tests   475 ✅ 40 💤 0 ❌
1 975 runs  1 926 ✅ 49 💤 0 ❌

Results for commit 4ec8119.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
fit	👶		$+0.03$	mmrm_gives_warning_if_not_reproducible_TMB_option_is_used
utils	👶		$+0.02$	h_tmb_warn_non_deterministic_works_as_expected
utils	💀	$0.02$	$-0.02$	h_tmb_warn_optimization_works_as_expected

Results for commit cf180ff

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ----------------------------
R/between-within.R             59       0  100.00%
R/component.R                  69       0  100.00%
R/cov_struct.R                 97       1  98.97%   407
R/empirical.R                   7       0  100.00%
R/fit.R                       230       3  98.70%   420, 482, 512
R/interop-car.R               130       1  99.23%   9
R/interop-emmeans.R            51       0  100.00%
R/interop-parsnip.R            59       1  98.31%   12
R/kenwardroger.R               92       2  97.83%   41, 63
R/mmrm-methods.R              140       0  100.00%
R/residual.R                    8       0  100.00%
R/satterthwaite.R             116      12  89.66%   238-249
R/skipping.R                    8       0  100.00%
R/testing.R                    64       4  93.75%   29, 31, 80, 82
R/tidiers.R                    72       2  97.22%   46-47
R/tmb-methods.R               294       3  98.98%   162, 306-307
R/tmb.R                       304       1  99.67%   206
R/utils-formula.R              27       0  100.00%
R/utils-nse.R                  16       0  100.00%
R/utils.R                     220      13  94.09%   283-293, 453, 482, 537
R/zzz.R                        72      26  63.89%   7-26, 59-64, 94, 122, 142
src/chol_cache.h               63       0  100.00%
src/covariance.h              101       1  99.01%   177
src/derivatives.h             126       0  100.00%
src/empirical.cpp              72       0  100.00%
src/exports.cpp                47       0  100.00%
src/jacobian.cpp               47       1  97.87%   54
src/kr_comp.cpp                56       0  100.00%
src/mmrm.cpp                   76       0  100.00%
src/predict.cpp                93       0  100.00%
src/test-chol_cache.cpp        58       5  91.38%   9, 18, 26, 55, 62
src/test-covariance.cpp       123       5  95.93%   9, 29, 40, 61, 72
src/test-derivatives.cpp      108       7  93.52%   44, 53, 62, 85, 94, 106, 124
src/test-utils.cpp            195       7  96.41%   9, 16, 24, 34, 44, 57, 119
src/testthat-helpers.h         15       5  66.67%   36-37, 41, 50, 53
src/utils.h                    78       0  100.00%
TOTAL                        3393     100  97.05%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/fit.R          +1       0  +0.01%
R/tmb.R          -1       0  -0.00%
R/utils.R        +4      +1  -0.35%
TOTAL            +4      +1  -0.03%

Results for commit: 4ec8119

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[kaskr]

@danielinteractive This looks right to me.

[luwidmer]

Can confirm this fixes the first-fit bug:

> source("~/.active-rstudio-document")
0.3.13.9000 
Res  1 :  903104ec4747c253d773e48e6ab96b32 
Res  2 :  903104ec4747c253d773e48e6ab96b32 
Res  3 :  903104ec4747c253d773e48e6ab96b32 
Res  4 :  903104ec4747c253d773e48e6ab96b32 
Res  5 :  903104ec4747c253d773e48e6ab96b32 

Also, I see the warnings trigger on TMB 1.9.14 as well as 1.9.15 with non-deterministic hash.