3.0: fix support for MPIEXEC_TIMEOUT #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
mpiexec_timeout
branch
3 times, most recently
from
1bd5638
to
c7e6041
Compare
linter fix for comparison of int to uint resulted in MPIEXEC_TIMEOUT env being ignored Signed-off-by: Min RK <benjaminrk@gmail.com> bot:notacherrypick
|
Took a while to figure out what was going on here, but I think I finally understand what happened and why this isn't a simple cherry-pick. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linter fix for comparison of int to uint resulted in MPIEXEC_TIMEOUT env being ignored. Affects openmpi >=5.0.3: open-mpi/ompi#12837
Regression introduced in the non-cherry-picked commit 7948675 in #1979 here to satisfy
devel-check.master already had this fix for this warning in #1940 here, this PR makes 3.0x match master.
bot:notacherrypick