From 167c372132510d163f098ba0443e33900eb6d04d Mon Sep 17 00:00:00 2001 From: Thomas Naughton Date: Thu, 3 Oct 2024 13:53:33 -0400 Subject: [PATCH] avoid warnings (as errors) spots (init vars, etc.) Signed-off-by: Thomas Naughton --- src/mca/ess/base/ess_base_std_prted.c | 10 +++++----- src/mca/odls/base/odls_base_default_fns.c | 3 ++- src/mca/plm/base/plm_base_frame.c | 4 ++-- src/mca/rmaps/base/rmaps_base_binding.c | 2 +- src/mca/schizo/prte/schizo_prte.c | 6 +++--- src/prted/pmix/pmix_server.c | 4 ++-- src/prted/pmix/pmix_server_allocate.c | 6 +++--- src/tools/prte_info/param.c | 4 ++-- 8 files changed, 20 insertions(+), 19 deletions(-) diff --git a/src/mca/ess/base/ess_base_std_prted.c b/src/mca/ess/base/ess_base_std_prted.c index 4e48cce7d6..2ee3470726 100644 --- a/src/mca/ess/base/ess_base_std_prted.c +++ b/src/mca/ess/base/ess_base_std_prted.c @@ -100,14 +100,14 @@ int prte_ess_base_prted_setup(void) char log_file[PATH_MAX]; char *error = NULL; char *uri = NULL; - char *tmp; - prte_job_t *jdata; + char *tmp = NULL; + prte_job_t *jdata = NULL; prte_proc_t *proc; - prte_app_context_t *app; + prte_app_context_t *app = NULL; hwloc_obj_t obj; unsigned i, j; - prte_topology_t *t; - prte_ess_base_signal_t *sig; + prte_topology_t *t = NULL; + prte_ess_base_signal_t *sig = NULL; int idx; pmix_value_t val; diff --git a/src/mca/odls/base/odls_base_default_fns.c b/src/mca/odls/base/odls_base_default_fns.c index 1ebd90eef8..210c2e14b8 100644 --- a/src/mca/odls/base/odls_base_default_fns.c +++ b/src/mca/odls/base/odls_base_default_fns.c @@ -939,7 +939,8 @@ void prte_odls_base_spawn_proc(int fd, short sd, void *cbdata) prte_job_t *jobdat = cd->jdata; prte_app_context_t *app = cd->app; prte_proc_t *child = cd->child; - int rc, i; + int rc = PRTE_SUCCESS; + int i; bool found; prte_proc_state_t state; pmix_proc_t pproc; diff --git a/src/mca/plm/base/plm_base_frame.c b/src/mca/plm/base/plm_base_frame.c index 2e2725b5a5..466396bad4 100644 --- a/src/mca/plm/base/plm_base_frame.c +++ b/src/mca/plm/base/plm_base_frame.c @@ -215,10 +215,10 @@ static int term_orteds(void) static void launch_daemons(int fd, short args, void *cbdata) { prte_state_caddy_t *state = (prte_state_caddy_t *) cbdata; - prte_job_t *daemons; + prte_job_t *daemons = NULL; int rc; prte_job_map_t *map = NULL; - prte_node_t *node; + prte_node_t *node = NULL; PRTE_HIDE_UNUSED_PARAMS(fd, args); /* setup the virtual machine */ diff --git a/src/mca/rmaps/base/rmaps_base_binding.c b/src/mca/rmaps/base/rmaps_base_binding.c index b6b2105e4e..fc5abe1cf7 100644 --- a/src/mca/rmaps/base/rmaps_base_binding.c +++ b/src/mca/rmaps/base/rmaps_base_binding.c @@ -56,7 +56,7 @@ static int bind_generic(prte_job_t *jdata, prte_proc_t *proc, prte_node_t *node, hwloc_obj_t obj, prte_rmaps_options_t *options) { - hwloc_obj_t trg_obj, tmp_obj; + hwloc_obj_t trg_obj = NULL, tmp_obj = NULL; unsigned ncpus; hwloc_obj_type_t type; hwloc_obj_t target; diff --git a/src/mca/schizo/prte/schizo_prte.c b/src/mca/schizo/prte/schizo_prte.c index 16507a6ae5..8f2102c0d1 100644 --- a/src/mca/schizo/prte/schizo_prte.c +++ b/src/mca/schizo/prte/schizo_prte.c @@ -454,10 +454,10 @@ static int convert_deprecated_cli(pmix_cli_result_t *results, static int parse_cli(char **argv, pmix_cli_result_t *results, bool silent) { - char *shorts, *helpfile; - struct option *myoptions; + char *shorts = NULL, *helpfile = NULL; + struct option *myoptions = NULL; int rc, n; - pmix_cli_item_t *opt; + pmix_cli_item_t *opt = NULL; if (0 == strcmp(prte_tool_actual, "prte")) { myoptions = prteoptions; diff --git a/src/prted/pmix/pmix_server.c b/src/prted/pmix/pmix_server.c index 9b57c11b3b..6c27e9d1c9 100644 --- a/src/prted/pmix/pmix_server.c +++ b/src/prted/pmix/pmix_server.c @@ -1808,7 +1808,7 @@ static void pmix_server_sched(int status, pmix_proc_t *sender, pmix_data_buffer_t *buffer, prte_rml_tag_t tg, void *cbdata) { - pmix_status_t rc; + pmix_status_t rc = PMIX_SUCCESS; uint8_t cmd; int32_t cnt; size_t ninfo; @@ -1816,7 +1816,7 @@ static void pmix_server_sched(int status, pmix_proc_t *sender, uint32_t sessionID; pmix_info_t *info = NULL; pmix_proc_t source; - pmix_server_req_t *req; + pmix_server_req_t *req = NULL; int refid; PRTE_HIDE_UNUSED_PARAMS(status, tg, cbdata); diff --git a/src/prted/pmix/pmix_server_allocate.c b/src/prted/pmix/pmix_server_allocate.c index e780837fc1..9cdb838129 100644 --- a/src/prted/pmix/pmix_server_allocate.c +++ b/src/prted/pmix/pmix_server_allocate.c @@ -248,9 +248,9 @@ static void pass_request(int sd, short args, void *cbdata) { pmix_server_req_t *req = (pmix_server_req_t*)cbdata; pmix_status_t rc; - size_t n; - pmix_info_t *xfer; - PRTE_HIDE_UNUSED_PARAMS(sd, args); + size_t n = 0; + pmix_info_t *xfer = NULL; + PRTE_HIDE_UNUSED_PARAMS(sd, args, n, xfer); /* add this request to our local request tracker array */ req->local_index = pmix_pointer_array_add(&prte_pmix_server_globals.local_reqs, req); diff --git a/src/tools/prte_info/param.c b/src/tools/prte_info/param.c index f17def0c2f..0408f76461 100644 --- a/src/tools/prte_info/param.c +++ b/src/tools/prte_info/param.c @@ -325,12 +325,12 @@ void prte_info_show_path(const char *type, const char *value) free(path); } -void prte_info_do_arch() +void prte_info_do_arch(void) { prte_info_out("Configured architecture", "config:arch", PRTE_ARCH); } -void prte_info_do_hostname() +void prte_info_do_hostname(void) { prte_info_out("Configure host", "config:host", PRTE_CONFIGURE_HOST); }