Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes invalid characters 0xfffe and 0xffff when cleaning XML #878

Merged

Conversation

karenhanson
Copy link
Contributor

This removes two additional forbidden characters when cleaning XML to be output by the XMLHandler in Utils.encodeContent() and Utils.encodeValue(). If you leave these characters in the XML, it generates an invalid character message during validation of JHOVE output.

Relates to #877

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +16.85% 🎉

Comparison is base (8a4d1ce) 30.15% compared to head (a3f3c23) 47.00%.
Report is 3 commits behind head on integration.

Additional details and impacted files
@@                Coverage Diff                 @@
##             integration     #878       +/-   ##
==================================================
+ Coverage          30.15%   47.00%   +16.85%     
- Complexity           651     1100      +449     
==================================================
  Files                 57       57               
  Lines               9079     9079               
  Branches            1622     1622               
==================================================
+ Hits                2738     4268     +1530     
+ Misses              5965     4280     -1685     
- Partials             376      531      +155     
Files Changed Coverage Δ
...src/main/java/edu/harvard/hul/ois/jhove/Utils.java 62.16% <ø> (+41.44%) ⬆️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karenhanson karenhanson mentioned this pull request Aug 31, 2023
@karenhanson
Copy link
Contributor Author

karenhanson commented Aug 31, 2023

This appears to address #880, which has a sample file attached that can be used for testing.

Update Oct 30, 23: from discussion on #880, this fixes the error message on that ticket, but does not address the underlying issue, which appears to be to do with how the bits are read in. The file on that ticket can be used to test though.

@carlwilson carlwilson merged commit dc65eb1 into openpreserve:integration Mar 4, 2024
4 checks passed
@carlwilson carlwilson added this to the JHOVE 1.30 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants