Empty properties causing extra indents in XmlHandler #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fix to move down the code that increments the indent level in XmlHandler.showProperty - when Utils.isPropertyEmpty is true, it indents unnecessarily causing misalignment in the XML.
|
OK, I see it's failing integration tests because it's comparing to XML files with the previous indents. Not sure where to find those files to update them... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this minor fix to move down the piece of code that increments the indent level in XmlHandler.showProperty. I kept noticing when running large batches the XML would gradually move across the page. I figured out that when Utils.isPropertyEmpty() comes back true, it increments the indent unnecessarily causing misalignment in the XML. This corrects the alignment issue.