Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Revert XML SAXParseException reporting #943

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

carlwilson
Copy link
Member

  • reverted to exception details in the main message with Line and Column numbers in the sub-message;
  • added dedicated method for reporting SAXParseExceptions to MessageConstants; and
  • fixed integration test results for XML SAXParseException reporting.

Closes #922

- reverted to exception details in the main message with Line and Column numbers in the sub-message;
- added dedicated method for reporting SAXParseExceptions to `MessageConstants`; and
- fixed integration test results for XML SAXParseException reporting.
@carlwilson carlwilson self-assigned this Aug 19, 2024
@carlwilson carlwilson added the bug A product defect that needs fixing label Aug 19, 2024
@carlwilson carlwilson added this to the JHOVE 1.32 milestone Aug 19, 2024
@carlwilson carlwilson merged commit 250f2db into integration Aug 19, 2024
6 checks passed
@carlwilson carlwilson deleted the fix/xml-reporting branch September 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML-hul: SaxParseException Info still hidden in subMessage attribute
1 participant