Separate out the python interface functions to different module #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SooluThomas
requested review from
bcdonovan,
taalexander,
kitbarton and
mbhealy
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
mbhealy
reviewed
Oct 26, 2023
kitbarton
previously requested changes
Oct 27, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
SooluThomas
commented
Oct 31, 2023
There was a problem hiding this comment.
Looking for better filename suggestions 😄
SooluThomas
commented
Oct 31, 2023
python_lib/qss_compiler/lib_enums.h
Outdated
There was a problem hiding this comment.
Same... Looking for better filename suggestions 😄
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the comment #124 (comment), to separate out the list of error categories
.value()enum as an include or macro so that this builder function doesn't continue to grow in lib.cpp as we continue to add more exceptions.The only way to get this done was to move out the python interface functions to a different file and to keep the enum in the same file.