Parameters Performance Improvements #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
taalexander
reviewed
Oct 30, 2023
Comment on lines
43
to
44
| static InitialValueType initial_values_; | ||
| static bool invalid_; |
There was a problem hiding this comment.
To avoid the usage of statics could we use the analysis system and preserve the analysis? https://mlir.llvm.org/docs/PassManagement/#preserving-analyses
bcdonovan
force-pushed
the
bd-performance-regression
branch
from
7dad980 to
a54ff88
Compare
bcdonovan
force-pushed
the
bd-performance-regression
branch
from
a54ff88 to
4ce6d31
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
taalexander
approved these changes
Nov 1, 2023
bcdonovan
added a commit
that referenced
this pull request
Nov 1, 2023
This PR adds performance improvements for working with parameters. Changes to MergeCircuitPass: * Remove some unused vectors * Change circuit merge so that only unique operands / arguments are added when merging circuits rather than the union of the two circuits arguments.
bcdonovan
added a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds performance improvements for working with parameters.
Changes to MergeCircuitPass:
Changes to ParameterInitialValueAnalysis: