FIX: always read nodata and undetect attributes from ODIM file #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@egouden Sorry for the delay here. Could you please fix the linter error. Otherwise this looks OK to me. |
egouden
force-pushed
the
odim_always_read_undetect_nodata
branch
from
479b316
to
ab2addd
Compare
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 19 19
Lines 3334 3334
=======================================
Hits 2941 2941
Misses 393 393
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kmuehlbauer
approved these changes
Sep 26, 2023
|
Thanks @egouden! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior is to not read ODIM undetect and nodata attributes if the values are not transformed (i.e. the attribute gain is 1 and the attribute offset is 0). This can lead to a loss of information. I think these attributes should always be read.