-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIN: restructure odim.py/gamic.py, add test_odim.py/test_gamic.py #154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 88.33% 89.91% +1.57%
==========================================
Files 20 20
Lines 3439 3421 -18
==========================================
+ Hits 3038 3076 +38
+ Misses 401 345 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@kmuehlbauer let me know when you need a review here! |
Thanks @mgrover1, it's still in the works. Combining this with gamic.py. I'll let you know, when this is ready for review. |
Sounds good :) exciting stuff! |
…DIM/GAMIC, add gamic tests
1e7e10b
to
f343e09
Compare
@mgrover1 This is ready for review. Essentially this is just a heavy refactor of the odim/gamic backend code with added tests. Test coverage increased by almost 1%. When this is merged I'll try to cover the last missing lines (at least for odim/gamic). |
@mgrover1 Pushed some more code which fit's in here. I'll leave this now as is for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmuehlbauer - this looks great. I like the way this is refactored, I think it really helps remove some of the duplication here. Thanks for also adding those more accurate dates across here.
Thanks @mgrover1, let's get this refactor in. The next changes won't be that voluminous. |
Restructure and add tests for
_OdimH5NetCDFMetadata
/_GamicH5NetCDFMetadata
. Refactor out_H5NetCDFMetadata
as parent class.history.md