Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIN: restructure odim.py/gamic.py, add test_odim.py/test_gamic.py #154

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Feb 23, 2024

Restructure and add tests for _OdimH5NetCDFMetadata/_GamicH5NetCDFMetadata. Refactor out _H5NetCDFMetadata as parent class.

  • Tests added
  • Changes are documented in history.md

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (236bafd) to head (cb3ab83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   88.33%   89.91%   +1.57%     
==========================================
  Files          20       20              
  Lines        3439     3421      -18     
==========================================
+ Hits         3038     3076      +38     
+ Misses        401      345      -56     
Flag Coverage Δ
notebooktests 0.00% <0.00%> (?)
unittests 89.91% <100.00%> (+1.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgrover1
Copy link
Collaborator

@kmuehlbauer let me know when you need a review here!

@kmuehlbauer
Copy link
Collaborator Author

Thanks @mgrover1, it's still in the works. Combining this with gamic.py. I'll let you know, when this is ready for review.

@kmuehlbauer kmuehlbauer marked this pull request as draft February 26, 2024 14:33
@mgrover1
Copy link
Collaborator

Sounds good :) exciting stuff!

@kmuehlbauer kmuehlbauer marked this pull request as ready for review February 27, 2024 13:44
@kmuehlbauer kmuehlbauer changed the title MIN: restructure odim.py, add test_odim.py MIN: restructure odim.py/gamic.py, add test_odim.py/test_gamic.py Feb 27, 2024
@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 This is ready for review. Essentially this is just a heavy refactor of the odim/gamic backend code with added tests.

Test coverage increased by almost 1%. When this is merged I'll try to cover the last missing lines (at least for odim/gamic).

@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 Pushed some more code which fit's in here. I'll leave this now as is for your review.

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmuehlbauer - this looks great. I like the way this is refactored, I think it really helps remove some of the duplication here. Thanks for also adding those more accurate dates across here.

xradar/io/backends/odim.py Show resolved Hide resolved
@kmuehlbauer
Copy link
Collaborator Author

Thanks @mgrover1, let's get this refactor in. The next changes won't be that voluminous.

@kmuehlbauer kmuehlbauer merged commit c0d63b8 into openradar:main Feb 27, 2024
12 checks passed
@kmuehlbauer kmuehlbauer deleted the odim-tests branch February 27, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants