NEXRAD Level2 structured reader #158
Conversation
|
Finally linting is good. Had outdated version on my machine 😬 |
|
This only reads the absolutely necessary metadata to get a hunch on sweeps/moments. Everything else is read when first requested by xarray (so it's lazy too). The reader uses numpy.memmap (like the sigmet reader). Will push the fixture in a minute... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 90.79% 91.30% +0.51%
==========================================
Files 20 21 +1
Lines 3421 3956 +535
==========================================
+ Hits 3106 3612 +506
- Misses 315 344 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mgrover1 Somehow my rebase threw away to much. Finally this is working again. Maybe we can talk in the next days, if necessary? |
|
yes! next week's radar community meeting? |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
This looks great - thanks for your hard work here @kmuehlbauer
|
The docs and test coverage look great - we can continue to iterate + test through other PRs - what do you think about merging @kmuehlbauer ? |
|
Let's wait after the meeting today. There are some issues which I want to show before we get this in. |
|
I am putting together a notebook right now comparing the data fields from Py-ART + xradar here as well... which should help us understand some of the differences? |
Great idea! One major difference is that this PR does not mask the data. We would need to think how we want to handle masking in the future. But we can make first make a list with the current differences. |
|
@mgrover1 If you think we should move forward from here, please go ahead and merge. I'll add several issues dedicated to different aspects/downsides of this implementation. Please also add any issues you find to the tracker, so that we can work on fixing enhancing. |
|
Great!! Agreed 😄 |
|
@kmuehlbauer - should we close out #40 here and open new issues related to more specific improvements? |
|
Ohh I like that idea... that can be the issue we refer back to + scaffold out. We can rename it to NEXRAD Support, and refer to the different readers and improvements. |
|
I created #160 to reflect this single reader, and modified #40 accordingly. Sound reasonable @kmuehlbauer ? |
|
@mgrover1 Yes, sounds good. |
history.mdThis is a rewrite of #147 using parts of the structured reader of the iris/sigmet reader. This also enhances the ability of reading much more metadata from the nexrad level 2 archive.
Note: this only implements MSG_31 as of now. MSG_1 need to be included after adding such file to open-radar-data repo.
There is also relevant code over in https://github.com/jthielen/xradar/tree/nexrad-level2 by @jthielen, which should be added to this structured reader in a follow-up PR.