-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding radar parameters to xradar iris datatree #166
Conversation
…s Table 301-1 and 301-4a in the FM 301-2022 WMO-CF RADIALREGULATIONS document
…ets, test_open_iris_datatree function was refactored to check the only the sweeps dataset within the iris datatree
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thanks so much @aladinor !
@kmuehlbauer - did you want to review as well? Otherwise, I think we can merge! |
wait one more thing - can you add this to the |
woo - sounds good! Yeah, @aladinor - please update that history.md file and we should be good to merge :) |
Thanks for adding yourself to the authors file as well!! 👍 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 91.33% 91.32% -0.02%
==========================================
Files 21 21
Lines 3969 4010 +41
==========================================
+ Hits 3625 3662 +37
- Misses 344 348 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We can ignore the codecov test here - it is flagging the history file - let's merge! |
Thanks @mgrover1 and @kmuehlbauer for your help and time! |
adding radar parameters to xradar iris datatree