Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding radar parameters to xradar iris datatree #166

Merged
merged 11 commits into from
Mar 29, 2024

Conversation

aladinor
Copy link
Member

@aladinor aladinor commented Mar 25, 2024

adding radar parameters to xradar iris datatree

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks so much @aladinor !

@mgrover1
Copy link
Collaborator

@kmuehlbauer - did you want to review as well? Otherwise, I think we can merge!

@mgrover1
Copy link
Collaborator

wait one more thing - can you add this to the docs/history.md file?

@kmuehlbauer
Copy link
Collaborator

@mgrover1 @aladinor I do not want to block this improvement. 👍 to merge if you are happy with it. We can iterate later, if needed. 😊

@mgrover1
Copy link
Collaborator

woo - sounds good! Yeah, @aladinor - please update that history.md file and we should be good to merge :)

@mgrover1
Copy link
Collaborator

Thanks for adding yourself to the authors file as well!! 👍

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.32%. Comparing base (2225bfa) to head (4fba5e9).

Files Patch % Lines
xradar/io/backends/iris.py 91.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   91.33%   91.32%   -0.02%     
==========================================
  Files          21       21              
  Lines        3969     4010      +41     
==========================================
+ Hits         3625     3662      +37     
- Misses        344      348       +4     
Flag Coverage Δ
notebooktests 80.57% <91.30%> (+0.09%) ⬆️
unittests 89.65% <91.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgrover1
Copy link
Collaborator

We can ignore the codecov test here - it is flagging the history file - let's merge!

@mgrover1 mgrover1 merged commit ebf2493 into openradar:main Mar 29, 2024
10 of 12 checks passed
@aladinor
Copy link
Member Author

Thanks @mgrover1 and @kmuehlbauer for your help and time!

@aladinor aladinor deleted the sigmet-radar-params branch March 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'DataTree' object has no attribute 'sweep_group_name'
3 participants