Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrr2 #172

Closed
wants to merge 50 commits into from
Closed

Mrr2 #172

wants to merge 50 commits into from

Conversation

rcjackson
Copy link
Contributor

I have added an xarray backend for reading the MRR2 .raw, .pro., and .avg files that are output by the Metek MRR2 software. The usage of the backend is similar to the ones currently implemented in xarray, with the MRR2 engine being 'metek.' In addition. the xd.io.load_metek_datatree command will load the MRR2 data into a DataTree.

  • Tests added
  • Changes are documented in history.md

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mgrover1
Copy link
Collaborator

@rcjackson - looks like some of the tests got hung up - rerunning to see if that is resolved! Thanks for the work so far here 😄

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 95.72368% with 13 lines in your changes missing coverage. Please review.

Project coverage is 92.17%. Comparing base (bd774ba) to head (0a92c88).

Files Patch % Lines
xradar/io/backends/metek.py 95.66% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   91.98%   92.17%   +0.18%     
==========================================
  Files          23       24       +1     
  Lines        4541     4842     +301     
==========================================
+ Hits         4177     4463     +286     
- Misses        364      379      +15     
Flag Coverage Δ
notebooktests 78.81% <88.15%> (+0.61%) ⬆️
unittests 90.49% <95.06%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer kmuehlbauer closed this Aug 2, 2024
@kmuehlbauer kmuehlbauer reopened this Aug 2, 2024
@kmuehlbauer kmuehlbauer mentioned this pull request Aug 2, 2024
3 tasks
@kmuehlbauer kmuehlbauer closed this Aug 2, 2024
@kmuehlbauer kmuehlbauer reopened this Aug 2, 2024
@kmuehlbauer
Copy link
Collaborator

@rcjackson I've tried to fix this but failed. Somehow the changes in this PR affect the CI so that it breaks for nexrad_leve2 tests. Locally everything works as expected, so not sure how to tackle this problem.

rcjackson and others added 29 commits August 23, 2024 10:13
* FIX: Fix use of ruff linting
* ADD: Add to history.md
* add numpy 1 and 2 runs
* fix numpy 2 casting issue in iris reader
* fix history.md

---------

Co-authored-by: Kai Mühlbauer <kai.muehlbauer@uni-bonn.de>
* ADD: datamet backend for italian C-band data

* ADD: add unit test for datamet backend

* ENH: support for .gz files in DataMet reader

* [ENH] black style formatting

* remove version.py

* make DataMetBackend discoverable

* fix tests

* fix entrypoint

* ENH: add tests for datamet xarray backend

* FIX: remove version.py

* ENH: added more tests for datamet format

* ENH: black fix

* FIX: fix E721 in type comparison (ruff)

* DOC: edited history.md

* FIX: changed xradar.io.backends.DataMetBackendEntrypoint to 'datamet'

* FIX: black formatting

---------

Co-authored-by: Kai Mühlbauer <kmuehlbauer@wradlib.org>
Co-authored-by: Kai Mühlbauer <kai.muehlbauer@uni-bonn.de>
* ADD: Unit tests for Halo Photonics reader

* ADD: History.md change

* FIX: Style issues

* FIX: Run black on code.

* ADD: Hpl module

* ADD: Halo Photonics reader example notebook

* Reformat Halo Photonics notebook
* FIX: time issue due to 1-based day count

* FIX: restructure retrieval of msg_31, do not try to read missing elevations, even when listed in msg_5

* add history.md entry

* add comment on radial_status 5
* REL: 0.6.0

* DOC: add hpl automodule directive

* MNT: add bobby and daniel to AUTHORS.md, fix CITATION.cff for new release

* MNT: set release date to 2024-08-05

* MNT: fix StreamLine HPL automodule header

* add orcids

* fix AUTHORS.md
* MNT: minimize CI
* add history.md entry
* FIX: properly read CfRadial1 n_points files

* add history.md entry

* only strip dimensions which are available

* restructure coordinate assignments

* add test, bump open-radar-data
…penradar#195)

* changing open_cfradial1_datatree engine from 'netcdf4' to 'h5netcdf'

* passing engine as a kwarg in open_cfradial_datatree function

* running pre-commit

* adding new development version, issue and, and PR to history.md file

* fixing some typos
* FIX: use correct rstart in meter for ODIM_H5/V2_4
* add history.md entry
@rcjackson rcjackson closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants