-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: properly read CfRadial1 n_points files #190
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 91.77% 90.24% -1.54%
==========================================
Files 23 23
Lines 4523 4531 +8
==========================================
- Hits 4151 4089 -62
- Misses 372 442 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For correct testing, do we already have a CfRadial1 file with Update: I'm adding one, see above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - nice fix @kmuehlbauer
I'll add a test, to work against any regression. |
The added test will need new open-radar-data v0.3 which will be in conda-forge within the next hours. So maybe we need to rerun the CI later if this fails now. v0.3 has already landed 🎉 |
* FIX: properly read CfRadial1 n_points files * add history.md entry * only strip dimensions which are available * restructure coordinate assignments * add test, bump open-radar-data
history.md