Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: properly read CfRadial1 n_points files #190

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Aug 7, 2024

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (2e8d6d3) to head (452649a).

Files Patch % Lines
xradar/io/backends/cfradial1.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   91.77%   90.24%   -1.54%     
==========================================
  Files          23       23              
  Lines        4523     4531       +8     
==========================================
- Hits         4151     4089      -62     
- Misses        372      442      +70     
Flag Coverage Δ
notebooktests ?
unittests 90.24% <94.73%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator Author

kmuehlbauer commented Aug 7, 2024

For correct testing, do we already have a CfRadial1 file with n_points dim in the open-radar-data repo?

Update: I'm adding one, see above.

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - nice fix @kmuehlbauer

@kmuehlbauer
Copy link
Collaborator Author

I'll add a test, to work against any regression.

@kmuehlbauer
Copy link
Collaborator Author

kmuehlbauer commented Aug 7, 2024

The added test will need new open-radar-data v0.3 which will be in conda-forge within the next hours. So maybe we need to rerun the CI later if this fails now.

v0.3 has already landed 🎉

@kmuehlbauer kmuehlbauer merged commit 49e0e72 into openradar:main Aug 7, 2024
9 of 11 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-cfradial1 branch August 7, 2024 14:21
rcjackson pushed a commit to rcjackson/xradar that referenced this pull request Aug 23, 2024
* FIX: properly read CfRadial1 n_points files

* add history.md entry

* only strip dimensions which are available

* restructure coordinate assignments

* add test, bump open-radar-data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: Dimensions {'n_points'} do not exist. when opening cfradial file
2 participants