Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lidar azimuth fix #206

Merged
merged 9 commits into from
Sep 19, 2024
Merged

Lidar azimuth fix #206

merged 9 commits into from
Sep 19, 2024

Conversation

rcjackson
Copy link
Contributor

I've fixed the naming of the "time" dimension to be "azimuth" to be consistent with the CF/Radial 2 standard for the Halo Photonics reader. In addition, a few fixes were made to the sweep variables.

  • Changes are documented in history.md

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.95%. Comparing base (71ebcc6) to head (0fbdad4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xradar/io/backends/hpl.py 90.62% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   91.97%   91.95%   -0.03%     
==========================================
  Files          23       23              
  Lines        4538     4562      +24     
==========================================
+ Hits         4174     4195      +21     
- Misses        364      367       +3     
Flag Coverage Δ
notebooktests 78.29% <90.62%> (+0.04%) ⬆️
unittests 90.22% <90.62%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@syedhamidali syedhamidali added the enhancement New feature or request label Sep 4, 2024
docs/history.md Outdated Show resolved Hide resolved
@kmuehlbauer kmuehlbauer merged commit a827a18 into openradar:main Sep 19, 2024
10 of 11 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks @rcjackson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants