Use non deprecated constructor (#18)

openrewrite · Jul 26, 2023 · fb1f022 · fb1f022
1 parent ca0bbd2
commit fb1f022
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 3 deletions.
diff --git a/src/main/java/org/openrewrite/java/dependencies/ChangeDependency.java b/src/main/java/org/openrewrite/java/dependencies/ChangeDependency.java
@@ -70,7 +70,6 @@ public class ChangeDependency extends Recipe {
     @Nullable
     private final String versionPattern;
 
-    // Maven only parameters
     @Option(displayName = "Override managed version",
             description = "If the new dependency has a managed version, this flag can be used to explicitly set the version on the dependency. The default for this flag is `false`.",
             required = false)
@@ -102,7 +101,7 @@ public List<Recipe> getRecipeList() {
                 !Objects.equals(changeGradleDependency.getNewVersion(), newVersion) ||
                 !Objects.equals(changeGradleDependency.getVersionPattern(), versionPattern)
         ) {
-            changeGradleDependency = new org.openrewrite.gradle.ChangeDependency(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern);
+            changeGradleDependency = new org.openrewrite.gradle.ChangeDependency(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern, overrideManagedVersion);
             changeMavenDependency = new org.openrewrite.maven.ChangeDependencyGroupIdAndArtifactId(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern, overrideManagedVersion);
         }
         return Arrays.asList(

diff --git a/src/test/java/org/openrewrite/java/dependencies/ChangeDependencyTest.java b/src/test/java/org/openrewrite/java/dependencies/ChangeDependencyTest.java
@@ -108,7 +108,7 @@ void changeMavenDependency() {
     }
 
     @Test
-    void doNotPinWhenNotVersioned() {
+    void doNotPinWhenNotVersionedGradle() {
         rewriteRun(
           spec -> spec
             .beforeRecipe(withToolingApi())
@@ -146,4 +146,44 @@ void doNotPinWhenNotVersioned() {
               """)
         );
     }
+
+    @Test
+    void pinWhenOverrideManagedVersionGradle() {
+        rewriteRun(
+          spec -> spec
+            .beforeRecipe(withToolingApi())
+            .recipe(new ChangeDependency("mysql", "mysql-connector-java", "com.mysql", "mysql-connector-j", "8.0.x", null, true)),
+          buildGradle(
+            """
+              plugins {
+                id 'java'
+                id 'org.springframework.boot' version '2.6.1'
+                id 'io.spring.dependency-management' version '1.0.11.RELEASE'
+              }
+              
+              repositories {
+                 mavenCentral()
+              }
+              
+              dependencies {
+                  runtimeOnly 'mysql:mysql-connector-java'
+              }
+              """,
+            """
+              plugins {
+                id 'java'
+                id 'org.springframework.boot' version '2.6.1'
+                id 'io.spring.dependency-management' version '1.0.11.RELEASE'
+              }
+              
+              repositories {
+                 mavenCentral()
+              }
+              
+              dependencies {
+                  runtimeOnly 'com.mysql:mysql-connector-j:8.0.33'
+              }
+              """)
+        );
+    }
 }