refactor: Common static analysis issues

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <team@moderne.io>
openrewrite · Jan 18, 2024 · 0746ec8 · 0746ec8
1 parent b10982f
commit 0746ec8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/org/openrewrite/xml/liberty/PersistenceXmlLocationRule.java b/src/main/java/org/openrewrite/xml/liberty/PersistenceXmlLocationRule.java
@@ -51,7 +51,7 @@ public File getProjectDirectory(File sourceFile, String projectName) {
     }
 
     public List<File> getSrcDirectories(SourceFile sourceFile) {
-        List<File> srcDirs = new ArrayList<File>();
+        List<File> srcDirs = new ArrayList<>();
         Path sourcePath = sourceFile.getSourcePath();
 
         String projectName = sourceFile.getMarkers()
@@ -65,7 +65,7 @@ public List<File> getSrcDirectories(SourceFile sourceFile) {
             if (subDirs != null) {
                 for (File subDir : subDirs) {
                     String dirName = subDir.getName().toLowerCase();
-                    if (dirName.endsWith("src") || dirName.equals("source")) {
+                    if (dirName.endsWith("src") || "source".equals(dirName)) {
                         srcDirs.add(subDir);
                     }
                 }
@@ -82,10 +82,10 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
             @Override
             public Tree visit(@Nullable Tree tree, ExecutionContext ctx) {
                 if (tree instanceof SourceFile) {
-                    SourceFile sourceFile = ((SourceFile) tree);
+                    SourceFile sourceFile = (SourceFile) tree;
 
                     Path sourcePath = ((SourceFile) tree).getSourcePath();
-                    if (sourcePath.getFileName().toString().equals("persistence.xml")) {
+                    if ("persistence.xml".equals(sourcePath.getFileName().toString())) {
                         String projectName = sourceFile.getMarkers()
                                 .findFirst(JavaProject.class)
                                 .map(JavaProject::getProjectName)